chore: Cleanup Access Layer

Author: Soap-141

src/app/ApplicationTemplate.Access/Configuration/SerializationConfiguration.cs

@@ -14,7 +14,7 @@ namespace ApplicationTemplate;
 [JsonSerializable(typeof(AuthenticationToken))]
 [JsonSerializable(typeof(AuthenticationData))]
 [JsonSerializable(typeof(ApplicationSettings))]
-[JsonSerializable(typeof(ProblemDetails))]
+[JsonSerializable(typeof(Refit.ProblemDetails))]
 [JsonSerializable(typeof(PostData))]
 [JsonSerializable(typeof(PostData[]))]
 [JsonSerializable(typeof(DadJokesResponse))]

src/app/ApplicationTemplate.Tests.Functional/ApplicationTemplate.Tests.Functional.csproj

@@ -12,6 +12,7 @@
 
 	<ItemGroup>
 		<PackageReference Include="AutoFixture.Xunit2" Version="4.18.1" />
+		<PackageReference Include="Microsoft.Extensions.TimeProvider.Testing" Version="9.3.0" />
 		<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.13.0" />
 		<PackageReference Include="NSubstitute" Version="5.3.0" />
 		<PackageReference Include="NSubstitute.Analyzers.CSharp" Version="1.0.17">

src/app/ApplicationTemplate.Tests.Unit/ApplicationTemplate.Tests.Unit.csproj

@@ -11,6 +11,7 @@
 
 	<ItemGroup>
 		<PackageReference Include="AutoFixture.Xunit2" Version="4.18.1" />
+		<PackageReference Include="Microsoft.Extensions.TimeProvider.Testing" Version="9.3.0" />
 		<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.13.0" />
 		<PackageReference Include="NSubstitute" Version="5.3.0" />
 		<PackageReference Include="NSubstitute.Analyzers.CSharp" Version="1.0.17">

src/app/ApplicationTemplate.Tests.Unit/AuthenticationServiceShould.cs

@@ -20,18 +20,18 @@ public sealed class AuthenticationServiceShould : IDisposable
 {
 	private readonly IAuthenticationService _authenticationService;
 	private readonly IApplicationSettingsRepository _applicationSettingsRepository;
-	private readonly IAuthenticationApiClient _authenticationRepository;
+	private readonly IAuthenticationApiClient _authenticationApiClient;
 	private readonly BehaviorSubject<ApplicationSettings> _applicationSettingsSubject;
 
 	public AuthenticationServiceShould()
 	{
 		_applicationSettingsRepository = Substitute.For<IApplicationSettingsRepository>();
-		_authenticationRepository = Substitute.For<IAuthenticationApiClient>();
+		_authenticationApiClient = Substitute.For<IAuthenticationApiClient>();
 
 		_authenticationService = new AuthenticationService(
 			Substitute.For<ILoggerFactory>(),
 			_applicationSettingsRepository,
-			_authenticationRepository
+			_authenticationApiClient
 		);
 
 		_applicationSettingsSubject = new BehaviorSubject<ApplicationSettings>(CreateApplicationSettings());
@@ -51,7 +51,7 @@ public async Task ReturnAuthenticationData_WhenLoggingIn()
 		var password = "password";
 		var authenticationData = CreateAuthenticationData(email: email);
 
-		_authenticationRepository.Login(Arg.Any<CancellationToken>(), Arg.Any<string>(), Arg.Any<string>()).Returns(authenticationData);
+		_authenticationApiClient.Login(Arg.Any<CancellationToken>(), Arg.Any<string>(), Arg.Any<string>()).Returns(authenticationData);
 
 		// Act
 		var result = await _authenticationService.Login(CancellationToken.None, email, password);
@@ -66,19 +66,22 @@ public async Task ReturnAuthenticationData_WhenRefreshingTheToken()
 		// Arrange
 		var email = "email";
 		var password = "password";
-		var refreshedEmail = "RefreshedEmail";
-		var authenticationData = CreateAuthenticationData(email: email);
-		var refreshAuthenticationData = CreateAuthenticationData(email: refreshedEmail);
+		var now = DateTimeOffset.Now;
+		var authenticationData = CreateAuthenticationData(email: email, now: now);
+
+		now = now.Add(TimeSpan.FromMinutes(1)); // Advance the time to simulate the token expiration.
+
+		var refreshAuthenticationData = CreateAuthenticationData(email: email, now: now);
 
-		_authenticationRepository.Login(Arg.Any<CancellationToken>(), Arg.Any<string>(), Arg.Any<string>()).Returns(authenticationData);
-		_authenticationRepository.RefreshToken(Arg.Any<CancellationToken>(), Arg.Any<AuthenticationData>()).Returns(refreshAuthenticationData);
+		_authenticationApiClient.Login(Arg.Any<CancellationToken>(), Arg.Any<string>(), Arg.Any<string>()).Returns(authenticationData);
+		_authenticationApiClient.RefreshToken(Arg.Any<CancellationToken>(), Arg.Any<AuthenticationData>()).Returns(refreshAuthenticationData);
 
 		// Act
 		var loginResult = await _authenticationService.Login(CancellationToken.None, email, password);
 		var result = await _authenticationService.RefreshToken(CancellationToken.None, new HttpRequestMessage(), loginResult);
 
 		// Assert
-		Assert.Equal(result.AccessToken.Payload.Email, refreshedEmail);
+		Assert.True(result.AccessToken.Payload.IssuedAt > loginResult.AccessToken.Payload.IssuedAt);
 	}
 
 	[Fact]
@@ -173,11 +176,11 @@ private void ResetApplicationSettings()
 		_applicationSettingsSubject.OnNext(CreateApplicationSettings());
 	}
 
-	private AuthenticationData CreateAuthenticationData(string email, bool isAccessTokenNull = false)
+	private AuthenticationData CreateAuthenticationData(string email, DateTimeOffset? now = null)
 	{
 		return new AuthenticationData
 		{
-			AccessToken = isAccessTokenNull ? null : new JwtData<AuthenticationToken>(AuthenticationApiClientMock.CreateJsonWebToken(email: email, serializerOptions: SerializationConfiguration.DefaultJsonSerializerOptions)),
+			AccessToken = new JwtData<AuthenticationToken>(AuthenticationApiClientMock.CreateJsonWebToken(email: email, now: now, serializerOptions: SerializationConfiguration.DefaultJsonSerializerOptions)),
 			RefreshToken = "RefreshToken",
 		};
 	}