-
Notifications
You must be signed in to change notification settings - Fork 10
chore: Cleanup Access Layer #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
01958a0
to
6a17814
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR cleans up the Access Layer by renaming repository classes to API clients, sealing classes, removing unused namespaces, and refactoring authentication data classes for improved consistency.
- Renames repositories to API clients (UserProfile, Posts) and seals classes.
- Removes unused import directives across several files.
- Refactors authentication token/data classes and adjusts related tests/code paths.
Reviewed Changes
Copilot reviewed 24 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
src/app/ApplicationTemplate.Access/ApiClients/UserProfile/UserProfileApiClientMock.cs | Renamed and sealed UserProfile API client; adjusted constructor signature. |
src/app/ApplicationTemplate.Access/ApiClients/UserProfile/IUserProfileApiClient.cs | Renamed interface and removed unused namespaces. |
src/app/ApplicationTemplate.Access/ApiClients/Posts/PostsApiClientMock.cs | Renamed and sealed Posts API client; streamlined using directives. |
src/app/ApplicationTemplate.Access/ApiClients/Posts/PostsApiClientException.cs | Added a new exception type for the posts API client. |
src/app/ApplicationTemplate.Access/ApiClients/Posts/PostRepositoryException.cs and PostErrorResponse.cs | Removed legacy classes no longer needed after refactoring. |
src/app/ApplicationTemplate.Access/ApiClients/Posts/IPostsApiClient.cs | Renamed interface and removed unused using directives. |
src/app/ApplicationTemplate.Access/ApiClients/Posts/Data/PostData.cs | Sealed the record type for post data. |
src/app/ApplicationTemplate.Access/ApiClients/Authentication/* | Refactored and relocated AuthenticationToken and AuthenticationData classes, updating to init-only properties and sealing classes. |
CHANGELOG.md | Updated changelog to reflect the cleanup and renaming changes. |
Files not reviewed (1)
- src/app/ApplicationTemplate.Access/ApplicationTemplate.Access.csproj: Language not supported
9a16e4a
to
1fbc9a4
Compare
src/app/ApplicationTemplate.Access/ApiClients/Authentication/AuthenticationApiClientMock.cs
Outdated
Show resolved
Hide resolved
src/app/ApplicationTemplate.Access/ApiClients/Authentication/Data/AuthenticationToken.cs
Outdated
Show resolved
Hide resolved
src/app/ApplicationTemplate.Access/ApiClients/Authentication/AuthenticationApiClientMock.cs
Outdated
Show resolved
Hide resolved
e0ea356
to
2b36b10
Compare
9955e9d
to
38a3627
Compare
src/app/ApplicationTemplate.Access/ApiClients/Authentication/AuthenticationApiClientMock.cs
Show resolved
Hide resolved
src/app/ApplicationTemplate.Access/Configuration/SerializationConfiguration.cs
Outdated
Show resolved
Hide resolved
src/app/ApplicationTemplate.Tests.Unit/AuthenticationServiceShould.cs
Outdated
Show resolved
Hide resolved
add66f1
to
3e03ac6
Compare
GitHub Issue: #
Proposed Changes
Description
Clean up the access layer by sealing classes and removing unused imports. I also made the authentication data classes as before (and adjusted places where needed based on those changes).
Impact on version
PR Checklist
Always applicable
No matter your changes, these checks always apply.
README.md
andTemplateConfig.md
if you made changes to templating.AzurePipelines.md
andAPP_README.md
if you made changes to pipelines.Diagnostics.md
if you made changes to diagnostic tools.Architecture.md
and its diagrams if you made architecture decisions or if you introduced new recipes.doc/
folder.Contextual
Based on your changes these checks may not apply.
Other information
Internal Issue (If applicable):