[mini.completion] No space between details.detail and details.description

[abeldekat]

Contributing guidelines

• I have read CODE_OF_CONDUCT.md

Module(s)

mini.completion

Question

See the picture above. The top part is my config, below is yours...

I think it can be solved here:

-- local label_detail = (details.detail or '') ..  (details.description or '')
local label_detail = details.detail or ''
label_detail = label_detail .. ((label_detail ~= '') and ' ' or '') .. (details.description or '')
label_detail = snippet_clue .. ((snippet_clue ~= '' and label_detail ~= '') and ' ' or '') .. label_detail

Slightly related: This feature request...)

Would you allow a PR adding the space?

[echasnovski]

See the picture above. The top part is my config, below is yours...

The current "no space" approach was taken directly from 'nvim-cmp'. And its roots are from completionItemLabelDetails which includes "without any spacing" (between label and detail), so the same is reasonable to apply to between detail and description.

Would you allow a PR adding the space?

Sure, sounds good. But it should have the same type of symmetric condition as for between snippet_clue and label_detail.

[abeldekat]

Thanks for the information!

According to the link to CompletionItemLabelDetails, "without any spacing" applies to label and detail, where label is defined in CompletionItem. I assume that CompletionItem.label corresponds to abbr?

In that case, stock blink.cmp renders according to spec.

Stock blink:

// blink default columns = { { 'kind_icon' }, { 'label', 'label_description', gap = 1 } },
// pseudo example:
kind_icon PhantomData<...>(use std:marker:PhantomData) gap PhantomData<unknown>>

When CompletionItemLabelDetails.details is appended to CompletionItem.label, as shown above, the parenthesis make more sense in my opinion...

We can close this question if you like. Otherwise, the best action is perhaps to change the formatting, appending CompletionItemLabelDetails.details to CompletionItem.label.

I would like to ask another question. When working with mini.completion, the S snippet indicator becomes redundant and slightly intrusive after a while.
I removed the indicator. For me, it's good enough that mini.snippets shows symbols after the snippet is expanded. Would you consider a configuration option to change the snippet symbol, allowing an empty string?

[echasnovski]

We can close this question if you like.

I've already said that adding a conditional space between detail and description sounds good.

Otherwise, the best action is perhaps to change the formatting, appending CompletionItemLabelDetails.details to CompletionItem.label.

Although it is according to spec, unfortunately merging details to abbr is not a 100% solution with built-in popup-menu because it will affect how matching characters are visualized. Using menu seems to be a better, "more native" approach here.

I would like to ask another question. When working with mini.completion, the S snippet indicator becomes redundant and slightly intrusive after a while.
I removed the indicator. For me, it's good enough that mini.snippets shows symbols after the snippet is expanded. Would you consider a configuration option to change the snippet symbol, allowing an empty string?

I considered that initially, but decided to go with always showing S detail. Similar to how "traditional" completion engines use ~ suffix in label. The reason some visual clue is needed here is because the item behaves significantly different form regular items.

The main issue here is selecting an item (for example, with a quick single <Tab> / <C-n>) and simply continuing typing will expand the snippet. If the user is not aware of that, it breaks the typing workflow: either by starting a full snippet session (with 'mini.snippets' showing tabstops) or by adding extra characters and moving cursor (without showing tabstops).

The other issue is that a word that is shown during up/down navigation is not necessarily (and usually in fact is not) the one that will be inserted.

It would have been redundant if this type of behavior was only for completion candidates with "Snippet" kind, but unfortunately LSP spec allows "snippet insert text format" for any other kind. So I'd like that snippet clue to be always visible.

[abeldekat]

Thanks! I will create the PR adding the space.