[mini.ai] Argument textobject and Python generics on new line

[Kayzels]

Contributing guidelines

• I have read CODE_OF_CONDUCT.md

Module(s)

mini.ai

Question

The argument textobject is incredibly useful, for deleting and moving arguments. I tend to use it very often. But there's a slight hiccup that sometimes happens.

Python puts generics for type hints inside square brackets, and arguments can be on new lines, inside parentheses:

def first_function(variable1: int, variable2: list[str]):
    pass

def second_function_with_very_long_name(
    variable1: int, variable2: list[str]
):
    pass

If I am anywhere in the first function and I delete an argument with daa, it works how I'd expect: the entire argument is removed. But in the second function, if I am anywhere on the argument line, and I do daa, it doesn't delete the argument how I'd expect. Instead, it deletes the value that's in the square brackets. If there isn't a square bracket generic on the line, then it works as expected.

This isn't expected behavior, but I'm not sure what I'd need to modify to fix this.

[echasnovski]

I am afraid this is expected with the default cover_or_next search method. Mostly as a combination of the following:

• The built-in argument textobject works only based on the text without any semantic understanding of the structure.
• First search is done inside current line and only then - inside neighborhood lines.

So in this case the str inside [] is recognized as a single argument (because it is inside balanced []) while there is no other arguments when taking only a single line into account (there is no other balanced brackets; they are on neighborhood lines). This makes 'mini.ai' do the following search:

• Search covering textobject in the current line. If cursor is not on str - there is none.
• Search next textobject in the current line. There usually is one and it is str, which is chosen.

Here are the ways to mitigate this:

• Use Visual mode first to iteratively select a necessary argument. For example, if the cursor is on variable1: vaa (selects str) followed by ala ("around last" + "a textobject") will select variable1: int,. Similarly, vaa + aa will select , variable2: list[str].
• Set config.search_method = 'cover' in favor of using "next" / "last" variants to explicitly search for non-covering textobject. In this case vaa when on variable1 will select its argument immediately.

[Kayzels]

I never thought to try doing aa after already having a selection, or ala (and I assume ana). Doing that works perfectly, thanks.