How to disable Enter to accept suggestion on with completeopt=noinsert

[TuTiuTe]

Contributing guidelines

• I have read CODE_OF_CONDUCT.md

Module(s)

mini.completion

Question

I like to have the first item selected by default so that as soon as I press <C-y> it's accepted.
I achieve that with vim.o.completeopt = 'noinsert'
However, I really dislike Enter to accept. With this, with how nvim works (see ins-completion-menu), it's considered to be in state 2 : A cursor key has been used to select another match. The match was not inserted then, only the entry in the popup menu is highlighted. and thus pressing enter inserts the first match

I recently changed to vim.o.completeopt = 'noselect' (which might already be default behavior) and made the following maps so that <C-y> selects the first option and <C-n> goes to the second completion (I am simulating the first entry being selected) with this

local function helper_pum(lhs)
	local info = vim.fn.complete_info({"selected", "pum_visible"})
	-- vim.notify(tostring(info.pum_visible) .. tostring(info.selected == -1) .. '\n', vim.log.levels.ERROR)
	if (info.pum_visible) and (info.selected == -1) then
		return '<C-n>' .. lhs
	end
	return lhs
end

map("i", "<C-y>", function() return helper_pum('<C-y>') end, {expr = true})
map("i", "<C-n>", function() return helper_pum("<C-n>") end, {expr = true})

This works fine enough with <C-y> but is not even triggered for <C-n> (the vim.notify is not displayed) only when the popup menu is active, seems to work fine otherwise.

My question is first: Is there a less hacky way to make this work with noinsert?
and then: If there is none, is there a way to make my solution work?

[echasnovski]

I like to have the first item selected by default so that as soon as I press it's accepted.
I achieve that with vim.o.completeopt = 'noinsert'
However, I really dislike Enter to accept.

Can you please clarify what would you like to happen when pressing <CR> when there is a pmenu visible? Is it basically "hide pmenu and start new line"? If yes, then this can be achieved with custom <CR> mapping in Insert mode. Something like this:

vim.keymap.set('i', '<CR>', [[pumvisible() ? "\<C-e>\<CR>" : "\<CR>"]], { expr = true })

You can also utilize MiniKeymap.map_multistep() to make it work with other uses of <CR>. Something like this:

local pmenu_dismiss = {
  condition = function() return vim.fn.pumvisible() == 1 end,
  action = function() return '<C-e><CR>' end,
}
MiniKeymap.map_multistep('i', '<CR>', { pmenu_dismiss, 'minipairs_cr' })

Does this answer your question?

[TuTiuTe]

it does, thank you very much

[TuTiuTe]

actually I have an issue with the treesitter now. Cursor is represented with |
Before, when I was writing C code like this

void main() {|}

Pressing enter would do

void main() {
  |
}

Now it just does

void main() {
|}

I guess it's an unintended consequence to inserting a literal enter. Is there a way to restore old behavior without compromises?

[echasnovski]

actually I have an issue with the treesitter now.

This doesn't look like a tree-sitter issue, but an "auto-pair" one.

I guess it's an unintended consequence to inserting a literal enter. Is there a way to restore old behavior without compromises?

The "You can also utilize MiniKeymap.map_multistep() to make it work with other uses of <CR>" part of the answer was addressing just that.

[TuTiuTe]

damn I should read more and not be in such a rush, thanks again