Skip to content

Commit d8acff3

Browse files
author
Sasha Morrissey
committed
Change the ChromeOS Audio Player to no longer use panels
Change the ChromeOS Audio Player to no longer use panels, but behave as a regular app. Panels are now deprecated. See the bug for more details. Bug: 800990 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia081ac12da133a31ca89719b501b373152a0441c Reviewed-on: https://chromium-review.googlesource.com/1011863 Reviewed-by: Ben Wells <[email protected]> Commit-Queue: Sasha Morrissey <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#550930}(cherry picked from commit 8b54e20) Reviewed-on: https://chromium-review.googlesource.com/1016140 Reviewed-by: Sasha Morrissey <[email protected]> Cr-Commit-Position: refs/branch-heads/3396@{#72} Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
1 parent d897749 commit d8acff3

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

ui/file_manager/audio_player/js/background.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,11 @@ var AUDIO_PLAYER_ICON = 'icons/audio-player-64.png';
1515
var AUDIO_PLAYER_APP_URL = 'audio_player.html';
1616

1717
/**
18-
* Configuration of the audio player panel.
18+
* Configuration of the audio player.
1919
* @type {Object}
2020
*/
2121
var audioPlayerCreateOptions = {
2222
id: 'audio-player',
23-
type: 'panel',
2423
minHeight: 4 + 48 + 96, // 4px: border-top, 48px: track, 96px: controller
2524
minWidth: 320,
2625
height: 4 + 48 + 96, // collapsed
@@ -113,7 +112,7 @@ function open(urls) {
113112
if (maybePosition !== -1)
114113
position = maybePosition;
115114

116-
// Opens the audio player panel.
115+
// Opens the audio player.
117116
return new Promise(function(fulfill, reject) {
118117
var urls = util.entriesToURLs(audioEntries);
119118
audioPlayer.launch({items: urls, position: position},

0 commit comments

Comments
 (0)