Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should all inlets be hot? #7

Open
nwolek opened this issue Jun 12, 2017 · 1 comment
Open

Should all inlets be hot? #7

nwolek opened this issue Jun 12, 2017 · 1 comment
Assignees
Labels

Comments

@nwolek
Copy link
Owner

nwolek commented Jun 12, 2017

It seems like there is a lot of extra patching needed to generate output from vbap with trigger objects (see attached screenshot). Would it be better to just make all inlets hot so that they generate output? Is there ever a situation when you would not want output?

Since this is a function change, we want to be careful. Making it an option is more difficult than just changing them to be hot.

And depending on the difficulty, I may need to tackle it later.

vbap_tbf

@jln-
Copy link
Collaborator

jln- commented Jun 12, 2017

While extra patching is bit annoying in simple situations like this help patch, I think being able to synchronize inlets is useful for optimization purpose. Below is a quick perf test patch that shows some significant differences (case 1°: as is, case 2°: azi & elev synchronized, case 3°: all inlets hot)

Maybe @matcham or @bltzr have strong opinion on this ? Do you guys think vbap's inlets should be hot ?

Maybe an option would be nice, but depending on how much work it is, I wonder whether it is worthing it (my impression is that it is not). If we were to put some time on vbap external, I tend to think we'd better revamp it from the ground up to modernize its interface (ie. specifying position as aed arrays) rather than adding options here and there. (just thinking out loud, here)

Test patch below:


----------begin_max5_patcher----------
1984.3oc6astiiZCE92YdJP4GUsRyR8ca5+1Wf9BrpZEIgYF1l.QDxzY2U8c
u9BjPRHCFrgjJM6rJDtX9r+74b74hyOeX17E4ukradveD7kfYy94Cylouj5B
ypNe17Mwusbc7N8iMeY9lMIYkyezbuxj2J0W+OyCRyVmTtKX22yV9RQdV5OR
VE7qwqWWeiWxK+s51ktR2p7Ee6SBZ8E2U980I5qWeksEI6jnEWllm80hjkkl
tJDDEEJDPDh8X.DhCAOF.p9H3upZa19MFfUsAVcwmxyJeJdYRyqsMtb4KoYO
2.fHFKDgHQb06mne+Hj4vYPjuurFCf5h+6COn93QGoyO+izM6KeI3WBRVm7p
d72F+1FcR5McxDnPAIxLZQDuylTD8B1j.mR17nPXWrG95rmKTfH5bF.NJLPV
x+HGFWP.utHda.H.z1HFN.0OfHLhaFNTHIjI+mRU7Bolk4qyKLMBDFw.bAQ8
.BDmPgpuAoLACKYiFMxPAkeeahokyWmtSNmFL+o04wu6WZWZk9dRljPd07Bk
cbffQR6KbpRq+pSOzoY5Az6oGJHJDCDHQjbPAP++c1IhQuxrizdh+mb1jraW
7yIWL6HjPKjbCUzx7CSze0Grb0KY2mhosZp8BF9JLGpelfXviVgwFq77HyJa
WkFqecKd9DYELmQ3ZIDrffgZoFxohIUs.0il7bQ7pTk46S.9oz0q0upuVyHU
xss7D5Og8pWdViOzeQQ.XjVoAChD.h4axKA63MT+BH3HDT+BjFJAH0WPTy2t
V6iyd1HAg3JghKefsE4ayKThS50GBwQs8V1Wl2jJ83xHkoaRJZSIHp+JADFW
I7ImXrSI3fwjNzF5PxWZUTAEl2gjOxirVvhfEsvZzAvZXBRa5iBri0VHkoTj
l9366LWGNtgfZzjtdOBL2h8kkRg5Vjr.Cmif7dvQNwMPAw3Ta8mWybp+Dp1+
iTkeXf17YfAGBoACUN7HFhfk7XZVY+ULa59EhnAkg6P7B6YEyi+0FShtNS1I
kX0wAH2cjyvLn1oHA2NWV49i6JhyVkuQ0CZi1vCP.jZBKJxx0CFj.GS5NLgf
4JuHIXMfbZW9.MUjFY.KhRggXrzeXznybRCC0Yb41wbPPqL2.xfjzUrwWbiS
42RR62UqPD1Fgw5OgwHBcOGy6i+Z8lxDxfhnQlbQQDFWDg2KxY7ASaiqb1Ij
1zKmImoWYVT6RebE8cAzdufHDeXrqGyLvHLxuVtAfPBITPgbNqkQOY.FlHXj
N4.H7Tlb.HPFGVcJ8pxNf.7Q1A9H6.tGmKgOTmn6ssfl0sAYh+SFZVGdEiF+
DjPFPVBIBjd0ODezSPxIZ+iYFRtZb9jAjKDHuJWHiYX9mTIv6qv7o.GBNcP9
YzLg7HB+FGud6IUCN1Qr6fwI5UhbuyxYHlnXPo3dvdCRDBBTYmSvI76vPvoj
Qe3CghC0Z+dKNZJc7G9QzPBDcql8uZDwTVOF5CLzVHhebU16sXao7Qet+jg+
HN2esX0PBZHlA3.TaNfz+ruEEALkwENoQpQomGnFx3o3GQp8QjZNFoFbxhTq
wFhpNPM58PfZfduNvvh3pgV7MIfKbznmXtl64s6qHmvroNxolh62z.mZiMn9
Njo9KpHFZjQzIJz.b+8OfabtCJFyT+CkAUduFNEBN19Tp1Fw2qQSA6e0hhLq
A.M6KuQRhAKi.8dLDLw3GAFNhb+F.1Xqqbxf+FD90pjmRyR95578q1sMI9uS
J1EfC.AehPCj+WcHxbFDaNEJLmiPlyktSqOhglyAAllZZYUCqZWUypZUUiNV
Ot0xtxx78FOqIWNav6ioqAX09XMKMa6opxpylD4v2Y6liemD.duucwa3DgC6
Vb8inkON62EkFQ00Okv2kuuXY8fqVzI3HRqR1UllEWGr2WN9qtnwCsIc01bo
VcEjpZ+1XOPHvXLDqxz.4fWjGu9QptXURw0EU7a+GXc+O5P+OhSaz+itZ+G3
T+Wsm8BnVx+tiDdJPRUUi.lkyItiDYxPBMYHAlDjv1hDzUjH1hDxUjn1hD1U
jX1hDwUMWls1ncFIpsH4J6wH1hjqRDLrsHA8gEVvjXgsRo7cQRsMNbdLo1NL
1gDvGH0E6Q8gcO012nSjp6NtMOY0Xh4qUM3cgD2WH0kGK0lgcGot7XodoE2Q
pKo75kKcWysSIBu3umMiI0uEN2WcOxVjbdLYilKyG18X13EVsAe2W0nS1C6K
j5xGVFwWH0ke4LpuPpqXMXdwtmUxddQy0JaDdQexl0mXdY8IgEHw8A6QrAIU
t0b22HalmTaUCmQRUBvt8ByGQpQf1hDvGH0E6g8grG1J+87grG1lH0v9vtGz
FMWU9QcNRMDzVjbMRMLwVjbVehZKR.efTW5SXhuPpqU2QPegTW9kC49Bot7i
vGpSBakGbMCKVkfEOLf3vdHg2u7hKrJs3nKpRQ71sulTrqpKn64y2D+MSUZ3
OpOMMybJVeZQxqo0OutrWyiKV9RZYxxx8Elx87V0OD44axk.msOspjBRN6gp
xBcVkQxh2XZ5m2uJMeS5alJFop3W790kmxqM1haU2n5NyleXiAdXau8X0c56
FBrpE8cW.dVMtrtUssg+TE4+7c4m9F5YPCapk9JjCzyK117MRdKstVHpo6G9
2G9O.UdCJQA
-----------end_max5_patcher-----------

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants