Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add database client to PyPi #69

Open
andybaumgar opened this issue Feb 12, 2023 · 10 comments
Open

Add database client to PyPi #69

andybaumgar opened this issue Feb 12, 2023 · 10 comments

Comments

@andybaumgar
Copy link
Collaborator

No description provided.

@Andrew-Dickinson
Copy link
Member

Andrew-Dickinson commented Feb 12, 2023

Help me understand this a bit more. You want to publish a copy of the Mesh spreadsheet client to PyPi? Is that for another project to use? IMO if it's going to get reused in multiple places it should probably have its own repo so you can do git submodules instead

@andybaumgar
Copy link
Collaborator Author

andybaumgar commented Feb 12, 2023

Yep, I'm using it for my analysis repo. Brian asked me to share with Marco, and I figured not making him clone multiple repos would be a nicer developer experience.

@Andrew-Dickinson
Copy link
Member

Andrew-Dickinson commented Feb 12, 2023 via email

@andybaumgar
Copy link
Collaborator Author

Could be, but I'd rather not have to update the PyPi every time I make an edit for Supportbot. The analysis script is just a extra thing.

@Andrew-Dickinson
Copy link
Member

Andrew-Dickinson commented Feb 12, 2023 via email

@andybaumgar
Copy link
Collaborator Author

andybaumgar commented Feb 12, 2023

That's a lot more steps. I don't see any problem with it being out of date on PyPi. Zip seems much more messy.

@andybaumgar
Copy link
Collaborator Author

I can put it in it's own repo, but that seems unproductive. It will go away with the Mesh API anyways.

@andybaumgar
Copy link
Collaborator Author

I can keep the PyPi up to date if it makes you happy. I'd rather not waste time moving it to it's own repo though. There are lots of other issues I could be working on instead.

@Andrew-Dickinson
Copy link
Member

Yeah don't worry about keeping it up-to-date I guess. I still think you should just send Marco a ZIP, but I guess uploading the ZIP to PyPi isn't that much more work

@andybaumgar
Copy link
Collaborator Author

There is actually an official package that does all the uploading. You run twine upload dist/* and it prompts for credentials and uploads. Most of the work was just setting up the extra package files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants