Skip to content

Universal React starter-kyt - Tools view #579

@nicanordlc

Description

@nicanordlc

Hi,

To what it’s worth this is not really crucial since the css file is pretty small but 🤷‍♂️

By looking around I found that in the kyt-universal-starter package that the shared-styles are being imported but not used.

You can see the file right here 👇 https://github.com/NYTimes/kyt/blob/4121828cf1c8061a90f1ed9f69979331bc4a02e1/packages/kyt-starter-universal/starter-src/src/components/Tools/styles.scss#L2-L6

I think that the $padding variable got forgotten.

One of this things can be done.

  • Use the variable $padding on the padding-top property (Values are differents)
  • In the case that the value must be 5px, one can create another value on the shared-styles like small-padding
  • Remove the import and leave the property with its current value

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions