Skip to content

Add Fallible Parsing #395

Open
Enhancement
@jonathan-g-davis

Description

@jonathan-g-davis

High level description

Input parsing functionality for dealing with SPICE kernel inputs contains several instances where malformed binary input may result in a panic. This enhancement will create new function signatures for structured error handling by using appropriate Result as return types instead of panicking.

Requirements

  • Modify ANISE to return structured errors instead of panicking
    • Use Result<T, E> where applicable
    • New error types may need to be created

Test plans

  • Include regression tests to reproduce error and prevent their reintroduction
  • Verify fixes with fuzz testing

Design

  • Maintain existing function signatures so as not to introduce breaking changes
  • Add new function signatures for fallible versions (e.g. try_parse_file)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions