ci: fix pipeline and add centos10

* Updated workflows to drop outdated centos 8 and implemented centos10 support.
* Removed rpmlint as build dependency due to it only being used in CI.
* Removed closed PRs from preseed list.

Signed-off-by: Jasper Berton <jasper.berton@team.blue>

Author: JasperB-TeamBlue

.copr/Makefile

@@ -1,11 +1,7 @@
 .PHONY: installdeps srpm
 
 installdeps:
-	dnf -y install git jq wget rpmlint nodejs
-	dnf \
-	    --repofrompath=ovirt-master-snapshot,https://download.copr.fedorainfracloud.org/results/ovirt/ovirt-master-snapshot/centos-stream-8-x86_64/ \
-	    install -y \
-	    ovirt-engine-nodejs-modules
+	dnf -y install git jq wget nodejs
 
 # explicity mark the copr generated git repo directory (which is done prior to the mock
 # call to the make_srpm and will be the current pwd) as safe for git commands

.github/workflows/check.yaml

@@ -9,14 +9,14 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - name: el8
-            container-image: quay.io/ovirt/buildcontainer:el8stream
           - name: el9
-            container-image: quay.io/ovirt/buildcontainer:el9stream
+            container-image: el9stream
+          - name: el10
+            container-image: el10stream
 
     name: ${{ matrix.name }}, run check.sh to verify content
     container:
-      image: ${{ matrix.container-image }}
+      image: quay.io/ovirt/buildcontainer:${{ matrix.container-image }}
 
     env:
       # The check version script needs to know the PR base and head commits to be able to
@@ -28,7 +28,8 @@ jobs:
     steps:
       - name: make sure check.sh required packages are installed
         run: |
-          dnf -y install git jq wget rpmlint
+          dnf -y install git jq wget nodejs
+          dnf -y install rpmlint || pip3 install rpmlint
 
       - name: checkout sources (PR head, not the PR merge)
         uses: ovirt/checkout-action@main
@@ -39,4 +40,5 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |
+          git config --global --add safe.directory "$GITHUB_WORKSPACE"
           ./automation/check.sh

.github/workflows/comment-to-build-pr.yaml

@@ -19,14 +19,14 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - name: el8
-            container-image: quay.io/ovirt/buildcontainer:el8stream
           - name: el9
-            container-image: quay.io/ovirt/buildcontainer:el9stream
+            container-image: el9stream
+          - name: el10
+            container-image: el10stream
 
     name: ${{ matrix.name }}, build the rpm repo
     container:
-      image: ${{ matrix.container-image }}
+      image: quay.io/ovirt/buildcontainer:${{ matrix.container-image }}
 
     env:
       CHECK_VERSION: no
@@ -40,6 +40,7 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |
+          git config --global --add safe.directory "$GITHUB_WORKSPACE"
           gh pr checkout --repo ${GITHUB_REPOSITORY} ${PR_NUMBER}
 
       - name: install build.sh required packages and most current nodejs-modules (as a fetch cache)

ovirt-engine-nodejs-modules.spec

@@ -1,6 +1,6 @@
 Name: ovirt-engine-nodejs-modules
 Version: 2.3.20
-Release: 1%{?dist}
+Release: 2%{?dist}
 Summary: Node.js modules required to build oVirt JavaScript applications
 Group: Virtualization/Management
 License: Multiple
@@ -14,7 +14,6 @@ BuildArch: noarch
 BuildRequires: git
 BuildRequires: jq
 BuildRequires: wget
-BuildRequires: rpmlint
 BuildRequires: rpm-build
 BuildRequires: nodejs >= 14.15.0
 
@@ -50,6 +49,10 @@ install -m 755 `find . -maxdepth 1 -name 'yarn-*.js' -exec basename {} \;` %{des
 %{_datadir}/%{name}
 
 %changelog
+* Wed May 28 2025 Jasper Berton <jasper.berton@team.blue> - 2.3.20-2
+  - removed rpmlint from build dependencies due to it only being used in CI.
+  - removed stale preseeds.
+
 * Thu Dec 15 2022 Sharon Gratch <sgratch@redhat.com> - 2.3.20-1
   - add preseed for https://github.com/oVirt/ovirt-web-ui/pull/1648
 

pre-seeds.list.mjs

@@ -15,7 +15,6 @@ export default {
     },
     folder: '/',
     pr: [
-      87,
     ]
   },
 
@@ -26,7 +25,6 @@ export default {
     },
     folder: '/',
     pr: [
-      1648,
     ]
   },