Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ethercalc / Etherpad square thumbnails do now show up on activity feed #1967

Closed
brecke opened this issue Dec 10, 2019 · 1 comment
Closed
Assignees
Milestone

Comments

@brecke
Copy link
Member

brecke commented Dec 10, 2019

Screenshot 2019-12-10 at 12 41 15

@brecke
Copy link
Member Author

brecke commented Apr 22, 2020

Ok, so here's the deal. This is no bug, but it is something we could enhance in the future. Here's what happens:

  • User A created doc, and an activity is created
  • That activity does not (and will never) have a preview. The doc doesn't have any content yet, so a generic icon is used, not a preview.
  • User A edits the doc, and exits. Another activity is created, which will have a proper preview.
  • Now we have two activities, a CREATED event (previewless) and an EDITED event (with a preview). Only the second is actually useful at this stage.

So we have two options the way I see it. We either:

  • Use a blank preview because at the time of creation it has no content
  • Erase the CREATED event as soon as an EDITED event is published

The problem with the former is that that preview will never be updated, so that is going to stay white forever. And that is misleading.

The problem with the latter is that it's too much work and probably too heavy for the benefit if has.

All in all, I am closing this bug and creating a superseding enhancement issue: #2122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant