test: add ExplicitImports checks (#14)

Author: oameye

Project.toml

@@ -6,7 +6,6 @@ version = "0.1.0"
 [deps]
 DocStringExtensions = "ffbed154-4ef7-542d-bbb7-c09d3a79fcae"
 LaTeXStrings = "b964fa9f-0449-5b57-a5c2-d3ea65f4040f"
-Printf = "de0858da-6303-5e67-8744-51eddeeeb8d7"
 
 [compat]
 Aqua = "0.8.11"
@@ -16,7 +15,6 @@ DocStringExtensions = "0.9.4"
 ExplicitImports = "1.11"
 JET = "0.9.18, 0.10"
 LaTeXStrings = "1.4"
-Printf = "1.10"
 Test = "1.10"
 julia = "1.10"
 

src/VanVleckRecursion.jl

@@ -3,8 +3,8 @@ $(DocStringExtensions.README)
 """
 module VanVleckRecursion
 
-using DocStringExtensions
-using Printf, LaTeXStrings
+using DocStringExtensions: DocStringExtensions
+using LaTeXStrings: LaTeXStrings
 
 # Export Kamiltonian and Generator functions
 export K, S, kamiltonian_get, generator_get, set_hamiltonian!, clear_caches!, latex

src/collections.jl

@@ -20,7 +20,7 @@ Key operations:
 Compute Poisson brackets between all pairs of terms from two collections.
 
 Implements distributive property: {A + B, C + D} = {A,C} + {A,D} + {B,C} + {B,D}.
-Essential for building K⁽ⁿ,ₖ⁾ expressions from lower-order terms.
+Essential for building K⁽ⁿ⁾,ₖ expressions from lower-order terms.
 
 # Arguments
 - `terms1::Terms`: First collection

src/display.jl

@@ -275,7 +275,7 @@ function latex(terms::Terms; advanced::Bool=true)
             s *= "\\\\ \n"
         end
     end
-    return latexstring(s)
+    return LaTeXStrings.latexstring(s)
 end
 
 # Display methods for Van Vleck recursion terms and collections
@@ -323,3 +323,6 @@ length(k3_terms)  # Number grows with recursion order
 ```
 """
 Base.length(terms::Terms) = length(terms.terms)
+
+# const T_LATEX = Union{<:QField,Diagrams,Diagram,Edge}
+# Base.show(io::IO, ::MIME"text/latex", x::T_LATEX) = write(io, latexify(x))

test/runtests.jl

@@ -20,8 +20,13 @@ end
 
 @testset "ExplicitImports" begin
     using ExplicitImports
-    @test check_no_stale_explicit_imports(VanVleckRecursion) == nothing
+    @test check_no_implicit_imports(VanVleckRecursion) == nothing
     @test check_all_explicit_imports_via_owners(VanVleckRecursion) == nothing
+    @test check_all_explicit_imports_are_public(VanVleckRecursion) == nothing
+    @test check_no_stale_explicit_imports(VanVleckRecursion) == nothing
+    @test check_all_qualified_accesses_via_owners(VanVleckRecursion) == nothing
+    @test check_all_qualified_accesses_are_public(VanVleckRecursion) == nothing
+    @test check_no_self_qualified_accesses(VanVleckRecursion) == nothing
 end
 
 @testset "best practices" begin
@@ -31,6 +36,14 @@ end
     Aqua.test_all(VanVleckRecursion; ambiguities=false)
 end
 
+@testset "Concretely typed" begin
+    import VanVleckRecursion as VVR
+    using CheckConcreteStructs
+
+    all_concrete(VVR.Term)
+    all_concrete(VVR.Terms)
+end
+
 # Include all test files
 include("types.jl")
 include("operations.jl")