Fix piping for commands needin wallet unlock

Author: ptrus

cmd/common/prompts.go

@@ -2,11 +2,16 @@ package common
 
 import (
 	"fmt"
+	"os"
 
 	"github.com/AlecAivazis/survey/v2"
 	"github.com/spf13/cobra"
 )
 
+// StdioOpts returns survey options for using stderr for prompts.
+// This ensures prompts are visible even when stdout is piped.
+var StdioOpts = survey.WithStdio(os.Stdin, os.Stderr, os.Stderr)
+
 var (
 	// PromptPassphrase is the standard passphrase prompt.
 	PromptPassphrase = &survey.Password{
@@ -27,12 +32,12 @@ var (
 // Confirm asks the user for confirmation and aborts when rejected.
 func Confirm(msg, abortMsg string) {
 	if answerYes {
-		fmt.Printf("? %s Yes\n", msg)
+		fmt.Fprintf(os.Stderr, "? %s Yes\n", msg)
 		return
 	}
 
 	var proceed bool
-	err := survey.AskOne(&survey.Confirm{Message: msg}, &proceed)
+	err := survey.AskOne(&survey.Confirm{Message: msg}, &proceed, StdioOpts)
 	cobra.CheckErr(err)
 	if !proceed {
 		cobra.CheckErr(abortMsg)
@@ -61,7 +66,7 @@ func AskNewPassphrase() string {
 			},
 		},
 	}
-	err := survey.Ask(questions, &answers)
+	err := survey.Ask(questions, &answers, StdioOpts)
 	cobra.CheckErr(err)
 
 	return answers.Passphrase

cmd/common/wallet.go

@@ -2,6 +2,7 @@ package common
 
 import (
 	"fmt"
+	"os"
 	"strings"
 
 	"github.com/AlecAivazis/survey/v2"
@@ -61,9 +62,10 @@ func LoadAccount(cfg *config.Config, name string) wallet.Account {
 	var passphrase string
 	if af.RequiresPassphrase() && !answerYes {
 		// Ask for passphrase to decrypt the account.
-		fmt.Printf("Unlock your account.\n")
+		// Use stderr for prompts so they work when stdout is piped.
+		fmt.Fprintln(os.Stderr, "Unlock your account.")
 
-		err = survey.AskOne(PromptPassphrase, &passphrase)
+		err = survey.AskOne(PromptPassphrase, &passphrase, StdioOpts)
 		cobra.CheckErr(err)
 	}
 

examples/account/allow-paratime.y.out

@@ -12,3 +12,4 @@ Fee:
 Network:  testnet
 ParaTime: none (consensus layer)
 Account:  oscar
+(In case you are using a hardware-based signer you may need to confirm on device.)

examples/account/allow.y.out

@@ -12,3 +12,4 @@ Fee:
 Network:  testnet
 ParaTime: none (consensus layer)
 Account:  oscar
+(In case you are using a hardware-based signer you may need to confirm on device.)

examples/account/amend-commission-schedule.y.out

@@ -21,3 +21,4 @@ Fee:
 Network:  testnet
 ParaTime: none (consensus layer)
 Account:  oscar
+(In case you are using a hardware-based signer you may need to confirm on device.)

examples/account/burn.y.out

@@ -11,3 +11,4 @@ Fee:
 Network:  testnet
 ParaTime: none (consensus layer)
 Account:  oscar
+(In case you are using a hardware-based signer you may need to confirm on device.)

examples/account/delegate-paratime.y.out

@@ -15,3 +15,4 @@ Fee:
 Network:  testnet
 ParaTime: sapphire
 Account:  oscar
+(In case you are using a hardware-based signer you may need to confirm on device.)

examples/account/delegate.y.out

@@ -12,3 +12,4 @@ Fee:
 Network:  testnet
 ParaTime: none (consensus layer)
 Account:  oscar
+(In case you are using a hardware-based signer you may need to confirm on device.)

examples/account/deposit-eth.y.out

@@ -15,3 +15,4 @@ Fee:
 Network:  testnet
 ParaTime: sapphire
 Account:  oscar
+(In case you are using a hardware-based signer you may need to confirm on device.)

examples/account/deposit-named.y.out

@@ -15,3 +15,4 @@ Fee:
 Network:  testnet
 ParaTime: sapphire
 Account:  oscar
+(In case you are using a hardware-based signer you may need to confirm on device.)