Fix piping for commands needing wallet unlock #653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
force-pushed
the
ptrus/fix/enable-piping-logs
branch
from
966c706 to
5516a8b
Compare
✅ Deploy Preview for oasisprotocol-cli ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ptrus
force-pushed
the
ptrus/fix/enable-piping-logs
branch
from
5516a8b to
0508824
Compare
matevz
approved these changes
Nov 26, 2025
| if !common.GetAnswerYes() { | ||
| fmt.Printf("WARNING: Removing the account will ERASE secret key material!\n") | ||
| fmt.Printf("WARNING: THIS ACTION IS IRREVERSIBLE!\n") | ||
| fmt.Fprintln(os.Stderr, "WARNING: Removing the account will ERASE secret key material!") |
Member
There was a problem hiding this comment.
There are a number of other warnings and hints throughout the code. Do you think all of those should now be redirected to stderr?
Member
Author
There was a problem hiding this comment.
Will update on all places yes (and introduce a helper method)
ptrus
force-pushed
the
ptrus/fix/enable-piping-logs
branch
from
0508824 to
384b13d
Compare
ptrus
force-pushed
the
ptrus/fix/enable-piping-logs
branch
from
384b13d to
aa9ee09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #628
This now works:
oasis rofl machine logs --deployment testnet | grep "res"