Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

politico.eu bypasses hush blocking, hush breaks Amazon ARC claims portal #202

Closed
eperitus opened this issue Aug 15, 2022 · 0 comments · Fixed by #208
Closed

politico.eu bypasses hush blocking, hush breaks Amazon ARC claims portal #202

eperitus opened this issue Aug 15, 2022 · 0 comments · Fixed by #208

Comments

@eperitus
Copy link

There's a giant message-overlay div that hush fails to block at:
https://www.politico.eu/article/the-first-100-days-in-liz-trusss-britain/

hush-politico-eu


Also, hush breaks the Amazon ARC claims portal (but this requires a login to see) because it blocks a terms of use modal and a separate privacy modal:
https://amazonexec.arcclaimsportal.com/Claimant/otpLogin

This is blocked, but ideally shouldn't be:

<!-- TOU Modal -->
<div class="modal fade" id="tou_modal" tabindex="-1" role="dialog" aria-labelledby="exampleModalLabel" aria-hidden="true">
          <div class="modal-dialog modal-lg" role="document">
            <div class="modal-content">
              <div class="modal-header">
                <h4 style="text-align:center;" class="modal-title" id="exampleModalLabel"><b>Online Claims Form Terms of Use</b></h4>
              </div>
              <div class="modal-body" style="max-height: 450px;overflow-x: hidden;overflow-y: scroll;">
...

Ideally, the web site designers wouldn't be using modals for terms of use agreements that you have to agree to before proceeding. Without agreeing to the hushed modals, you end up with a form that you can't scroll down on. (Took me half an hour to figure out hush was the culprit.)

I gave feedback to the exec team at Amazon ARC on this but figured you might want to know too. Thanks for the great extension - it saves a lot of time and annoyances on many other sites! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant