fix: read the default TTL at call time (#24)

Trying to read the environment variable at package load time doesn't
workt with Obot.

Signed-off-by: Donnie Adams <[email protected]>

Author: thedadams

pkg/leader/leader.go

@@ -13,20 +13,13 @@ import (
 	"k8s.io/client-go/tools/leaderelection/resourcelock"
 )
 
-var defaultLeaderTTL = time.Minute
-
 const (
-	devLeaderTTL = time.Hour
+	defaultLeaderTTL = time.Minute
+	devLeaderTTL     = time.Hour
 
 	FileLockType = "file"
 )
 
-func init() {
-	if os.Getenv("NAH_DEV_MODE") != "" {
-		defaultLeaderTTL = devLeaderTTL
-	}
-}
-
 type OnLeader func(context.Context) error
 type OnNewLeader func(string)
 
@@ -38,7 +31,7 @@ type ElectionConfig struct {
 
 func NewDefaultElectionConfig(namespace, name string, cfg *rest.Config) *ElectionConfig {
 	return &ElectionConfig{
-		TTL:              defaultLeaderTTL,
+		TTL:              defaultElectionTTL(),
 		Namespace:        namespace,
 		Name:             name,
 		ResourceLockType: resourcelock.LeasesResourceLock,
@@ -48,7 +41,7 @@ func NewDefaultElectionConfig(namespace, name string, cfg *rest.Config) *Electio
 
 func NewFileElectionConfig(fileName string) *ElectionConfig {
 	return &ElectionConfig{
-		TTL:              defaultLeaderTTL,
+		TTL:              defaultElectionTTL(),
 		Name:             fileName,
 		ResourceLockType: FileLockType,
 	}
@@ -72,6 +65,13 @@ func NewElectionConfig(ttl time.Duration, namespace, name, lockType string, cfg
 	}
 }
 
+func defaultElectionTTL() time.Duration {
+	if os.Getenv("NAH_DEV_MODE") != "" {
+		return devLeaderTTL
+	}
+	return defaultLeaderTTL
+}
+
 func (ec *ElectionConfig) Run(ctx context.Context, id string, onLeader OnLeader, onSwitchLeader OnNewLeader, signalDone func()) error {
 	if ec == nil {
 		// Don't start leader election if there is no config.