fix: incorrect fallback for resolve note

Author: neo451

CHANGELOG.md

@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
 
 - Fixed incorrect call signature for `options.callbacks.post_set_workspace`
+- Fixed incorrect fallback for `resolve_note`.
 
 ## [v3.13.0](https://github.com/obsidian-nvim/obsidian.nvim/releases/tag/v3.13.0) - 2025-07-28
 
@@ -350,7 +351,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 There's a lot of new features and improvements here that I'm really excited about 🥳 They've improved my workflow a ton and I hope they do for you too. To highlight the 3 biggest additions:
 
 1. 🔗 Full support for header anchor links and block links! That means both for following links and completion of links. Various forms of anchor/block links are support. Here are a few examples:
-
    - Typical Obsidian-style wiki links, e.g. `[[My note#Heading 1]]`, `[[My note#Heading 1#Sub heading]]`, `[[My note#^block-123]]`.
    - Wiki links with a label, e.g. `[[my-note#heading-1|Heading 1 in My Note]]`.
    - Markdown links, e.g. `[Heading 1 in My Note](my-note.md#heading-1)`.

lua/obsidian/api.lua

@@ -612,64 +612,56 @@ M.follow_link = function(link, opts)
   opts = opts and opts or {}
   local Note = require "obsidian.note"
 
-  search.resolve_link_async(link, function(result)
-    if not result then
+  ---@param res obsidian.ResolveLinkResult
+  local function follow_link(res)
+    if res.url ~= nil then
+      Obsidian.opts.follow_url_func(res.url)
       return
     end
 
-    ---@param res obsidian.ResolveLinkResult
-    local function follow_link(res)
-      if res.url ~= nil then
-        Obsidian.opts.follow_url_func(res.url)
-        return
-      end
-
-      if util.is_img(res.location) then
-        local path = Obsidian.dir / res.location
-        Obsidian.opts.follow_img_func(tostring(path))
-        return
-      end
+    if util.is_img(res.location) then
+      local path = Obsidian.dir / res.location
+      Obsidian.opts.follow_img_func(tostring(path))
+      return
+    end
 
-      if res.note ~= nil then
-        -- Go to resolved note.
-        return res.note:open { line = res.line, col = res.col, open_strategy = opts.open_strategy }
-      end
+    if res.note ~= nil then
+      -- Go to resolved note.
+      return res.note:open { line = res.line, col = res.col, open_strategy = opts.open_strategy }
+    end
 
-      if res.link_type == search.RefTypes.Wiki or res.link_type == search.RefTypes.WikiWithAlias then
-        -- Prompt to create a new note.
-        if M.confirm("Create new note '" .. res.location .. "'?") then
-          -- Create a new note.
-          ---@type string|?, string[]
-          local id, aliases
-          if res.name == res.location then
-            aliases = {}
-          else
-            aliases = { res.name }
-            id = res.location
-          end
-
-          local note = Note.create { title = res.name, id = id, aliases = aliases }
-          return note:open {
-            open_strategy = opts.open_strategy,
-            callback = function(bufnr)
-              note:write_to_buffer { bufnr = bufnr }
-            end,
-          }
+    if res.link_type == search.RefTypes.Wiki or res.link_type == search.RefTypes.WikiWithAlias then
+      -- Prompt to create a new note.
+      if M.confirm("Create new note '" .. res.location .. "'?") then
+        -- Create a new note.
+        ---@type string|?, string[]
+        local id, aliases
+        if res.name == res.location then
+          aliases = {}
         else
-          log.warn "Aborted"
-          return
+          aliases = { res.name }
+          id = res.location
         end
-      end
 
-      return log.err("Failed to resolve file '" .. res.location .. "'")
+        local note = Note.create { title = res.name, id = id, aliases = aliases }
+        return note:open {
+          open_strategy = opts.open_strategy,
+          callback = function(bufnr)
+            note:write_to_buffer { bufnr = bufnr }
+          end,
+        }
+      else
+        log.warn "Aborted"
+        return
+      end
     end
 
-    -- if #results == 1 then
-    return vim.schedule(function()
-      follow_link(result)
-    end)
-  end, { pick = true })
+    return log.err("Failed to resolve file '" .. res.location .. "'")
+  end
+
+  search.resolve_link_async(link, vim.schedule_wrap(follow_link), { pick = true })
 end
+
 --------------------------
 ---- Mapping functions ---
 --------------------------

lua/obsidian/commands/backlinks.lua

@@ -94,8 +94,7 @@ return function(client)
 
     search.resolve_note_async(location, function(note)
       if not note then
-        log.err("No notes matching '%s'", location)
-        return
+        return log.err("No notes matching '%s'", location)
       else
         return collect_backlinks(client, picker, note, opts)
       end

lua/obsidian/commands/link.lua

@@ -6,7 +6,7 @@ local log = require "obsidian.log"
 return function(_, data)
   local viz = api.get_visual_selection()
   if not viz then
-    log.err "ObsidianLink must be called with visual selection"
+    log.err "`Obsidian link` must be called with visual selection"
     return
   elseif #viz.lines ~= 1 then
     log.err "Only in-line visual selections allowed"
@@ -16,11 +16,11 @@ return function(_, data)
   local line = assert(viz.lines[1])
 
   ---@type string
-  local search_term
+  local query
   if data.args ~= nil and string.len(data.args) > 0 then
-    search_term = data.args
+    query = data.args
   else
-    search_term = viz.selection
+    query = viz.selection
   end
 
   ---@param note obsidian.Note
@@ -32,7 +32,10 @@ return function(_, data)
     require("obsidian.ui").update(0)
   end
 
-  search.resolve_note_async(search_term, function(note)
+  search.resolve_note_async(query, function(note)
+    if not note then
+      return log.err("No notes matching '%s'", query)
+    end
     vim.schedule(function()
       insert_ref(note)
     end)

lua/obsidian/commands/quick_switch.lua

@@ -13,6 +13,9 @@ return function(_, data)
     picker:find_notes()
   else
     search.resolve_note_async(data.args, function(note)
+      if not note then
+        return log.err("No notes matching '%s'", data.args)
+      end
       note:open()
     end)
   end

lua/obsidian/path.lua

@@ -10,7 +10,7 @@ end
 
 ---@param path table
 ---@param k string
----@param factory fun(obsidian.Path): any
+---@param factory fun(path: obsidian.Path): any
 local function cached_get(path, k, factory)
   local cache_key = "__" .. k
   local v = rawget(path, cache_key)

lua/obsidian/search.lua

@@ -736,7 +736,7 @@ end
 --- Resolve a note, opens a picker to choose a single note when there are multiple matches.
 ---
 ---@param query string
----@param callback fun(obsidian.Note)
+---@param callback fun(note: obsidian.Note|nil)
 ---@param opts { notes: obsidian.note.LoadOpts|?, prompt_title: string|?, pick: boolean }|?
 ---
 ---@return obsidian.Note|?
@@ -746,7 +746,7 @@ M.resolve_note_async = function(query, callback, opts)
 
   _resolve_note_async(query, function(notes)
     if #notes == 0 then
-      return log.err("No notes matching '%s'", query)
+      return callback()
     elseif #notes == 1 then
       return callback(notes[1])
     end