Blink Completion Not Working?

[sghng]

opts = {
	ui = { enable = false }, -- use render-markdown instead
	workspaces = { { name = "TECH", path = OBSIDIAN_VAULT } },
	completion = { blink = true },
	disable_frontmatter = true,
	picker = { name = "telescope.nvim" },
	mappings = {}, -- disable default mappings
	open = {
		func = function(uri)
			vim.ui.open(uri, { cmd = { "open", "-a", "/Applications/Obsidian.app" } })
		end,
	},
},

Blink completion shows up in health check:

However, I still don't get completions when typing double brackets. I'm not sure if Obsidian source should show up in Blink:

[sghng]

Not sure if this is relevant: after enabling Obsidian completions for Blink, BlinkCmp status will occasionally cause Neovim to crash.

[neo451]

can you give a bit more context?
like is it stopped working after some update or you are using the first time?

[sghng]

I just moved from the upstream to this fork, but I never got completion to work before (since upstream doesn't support blink). Blink worked fine for me for other completion sources.

[santoshkal]

Hi, thanks for the fork, and for keeping the plugin rolling. I've just migrated to the fork. But, as above, I am unable to get blink to work with my setup.
I have set this up in blink, as mentioned in the blink docs:

sources.min_keyword_length = function()
  return vim.bo.filetype == 'markdown' and 2 or 0
end

And have disabled nvim_cmp and enabled blink. Still, unable to make this work.

[neo451]

@sghng Sorry this one fell out of my radar, is it working now?
@santoshkal can you show me your config?

Also, try to copy the minimal.lua in the repo, or just in this plugins directory, uncomment the completion engine part in the file, run nvim -u minimal.lua, and see if it works.

[santoshkal]

Heres my config:

return {
  "obsidian-nvim/obsidian.nvim",
  version = "*", -- recommended, use latest release instead of latest commit
  lazy = false,
  ft = "markdown",
  dependencies = {
    -- Required.
    "nvim-lua/plenary.nvim",

    -- see above for full list of optional dependencies ☝️
  },
  opts = {
    -- Creates a new Note with the title.md format
    note_id_func = function(title)
      return title
    end,

    workspaces = {
      {
        name = "DevOps",
        path = "~/Dropbox/devops/",
        overrides = {
          notes_subdir = "00-Inbox",
        },
      },
    },
    notes_subdir = "00-Inbox",
    completion = {
      nvim_cmp = false,
      blink = true,
      min_chars = 0,
    },
    new_notes_location = "notes_subdir",

    disable_frontmatter = true,

    -- see below for full list of options 👇
    templates = {
      folder = "templates",
      date_format = "%Y%m%d%H%M",
    },
    picker = {
      name = "fzf-lua",
      note_mappings = {
        new = "<C-x>",
        -- Insert a link to the selected note.
        insert_link = "<C-l>",
      },
    },
    mappings = {
      ["<cr>"] = {
        action = function()
          return require("obsidian").util.smart_action()
        end,
        opts = { buffer = true, expr = true },
      },
      ["gd"] = {
        action = function()
          return require("obsidian").util.gf_passthrough()
        end,
        opts = { noremap = false, expr = true, buffer = true },
      },
    },
    ui = {
      enabled = false,
    },
  },
}

[jakubdonovan]

@sghng Sorry this one fell out of my radar, is it working now? @santoshkal can you show me your config?

Also, try to copy the minimal.lua in the repo, or just in this plugins directory, uncomment the completion engine part in the file, run nvim -u minimal.lua, and see if it works.

Hi, I'm also unable to get blink completions to work despite them working properly for supermaven.

plugins/spec/obsidian.lua

return {
  "obsidian-nvim/obsidian.nvim",
  version = "*", -- recommended, use latest release instead of latest commit
  lazy = false,
  ft = "markdown",
  dependencies = {
    -- Required.
    "nvim-lua/plenary.nvim",
    "saghen/blink.cmp",
  },
  ---@module 'obsidian'
  ---@type obsidian.config
  opts = {
    ui = {
      enable = false,
    },
    workspaces = {
      {
        name = "notes",
        path = "~/vaults/personal/notes",
      },
    },
    completion = {
      nvim_cmp = false,
      blink = true,
      min_chars = 1,
    },
  },
}

plugins/spec/blink.lua

return {
  { import = "nvchad.blink.lazyspec" },
  {
    "saghen/blink.cmp",
    dependencies = {
      {
        "supermaven-inc/supermaven-nvim",
        opts = {},
        cmd = "SupermavenUseFree",
      },
      "huijiro/blink-cmp-supermaven",
    },
    ---@module 'blink.cmp'
    ---@type blink.cmp.Config
    opts = {
      keymap = {
        ["<Tab>"] = { "select_next", "snippet_forward", "fallback" },
        ["<S-Tab>"] = { "select_prev", "snippet_backward", "fallback" },
      },
      completion = {
        ghost_text = {
          enabled = true,
        },
      },
      snippets = {
        jump = function(direction)
          require("luasnip").jump(direction)
        end,
      },
      cmdline = {
        keymap = { preset = "inherit" },
        completion = { menu = { auto_show = true } },
      },
      sources = {
        default = { "lsp", "snippets", "buffer", "path", "supermaven" },
        per_filetype = {
          codecompanion = { "codecompanion" },
        },
        providers = {
          supermaven = {
            name = "supermaven",
            module = "blink-cmp-supermaven",
            async = true,
          },
        },
      },
    },
  },
}

BlinkCmp status

ObsidianDebug

[neo451]

@sghng @jakubdonovan

try removing version = "*" in your configs, it might be working if you are on the main, though I don't see how that is the case.

I have ran out of ideas on why it is not working now.

as #52 suggests, completion source are not sustainable and prune to failure for us, so It will eventually just lsp completion for markdown buffers, it will surely work then. Before that, maybe one of you would like to just do some print debugging on your environment to track down the issue.

[jakubdonovan]

@sghng @jakubdonovan

try removing version = "*" in your configs, it might be working if you are on the main, though I don't see how that is the case.

I have ran out of ideas on why it is not working now.

as #52 suggests, completion source are not sustainable and prune to failure for us, so It will eventually just lsp completion for markdown buffers, it will surely work then. Before that, maybe one of you would like to just do some print debugging on your environment to track down the issue.

Removing version = "*" from my config has not made any difference. I'm happy to help you debug this if you tell me what to do.

[santoshkal]

Same at my end as well.

I tried using blink.compat. Not working.

[neo451]

@sghng @santoshkal
let's start by inserting a vim.print(items) here

obsidian.nvim/lua/obsidian/completion/sources/base/new.lua

Line 174 in 70087b1

also vim.print(cc) would be helpful.

[santoshkal]

Tried inserting these debug lines at the locations you suggested.
When I activate completion for a file in Valut by pressing [[, these are not printed in :messages,
In command mode, vim.print(items) and vim.print(cc) returns nil.

[jdlabelle]

Also ran into this issue. It looks like this is due to an update to blink.cmp within the last 8 weeks (that is when my lockfile goes back to). Once I restored to my lockfile, blink completion worked again. No updates to Obsidian.nvim were made during that time according to Lazy.

[neo451]

@sghng @jakubdonovan

look at the comment above, It could be blink's api change, for now recommend you two to add version = '1.*', in your blink spec.

[jakubdonovan]

@santoshkal that is great, @sghng @jakubdonovan try this?

I just tried it and it did not make a difference

[sghng]

I added sources.per_filetype.markdown = { "obsidian" } in my blink config and it worked for me.

This doesn't work for me, seems like the obsidian provider doesn't exist

[neo451]

@sghng if it don't exist, maybe add obsidian.nvim to blink.cmp's dependencies field

[sghng]

@sghng if it don't exist, maybe add obsidian.nvim to blink.cmp's dependencies field

Now it complains that the provider obsidian is not configured.

[jakubdonovan]

@sghng if it don't exist, maybe add obsidian.nvim to blink.cmp's dependencies field

It still does not work for me with my configuration.

[neo451]

@sghng @jakubdonovan @santoshkal

let's try this again, this time:

1. make sure you are on the main or 3.13
2. copied your blink.cmp config, :BlinkCmp status, obsidian config and :checkhealth obsidian, preferably in just text.

[sghng]

In case this helps, I had the same issue and it turned out to be because of my render-markdown.nvim config. I had to remove the below from the config:

completions = { blink = { enabled = true } }

Thanks for this, however I don't have render-markdown.nvim completion through Blink. Besides, for my config, render-markdown completions through Blink actually doesn't work, switching to completion through LSP somehow works.

[jdlabelle]

@sghng This was the fix for me as well. I commented this out from my render-markdown.nvim config file and completions work as expected.

[sghng]

For clarification, here's what I have in render-markdown config:

completions = { lsp = { enabled = true } },

Completion from render markdown actually stops working if I replace lsp with blink.

[jdlabelle]

I can confirm this exact behavior as well

[sghng]

Not relevant to this obsidian plugin, but a related issue I created about completion bug in render-markdown: MeanderingProgrammer/render-markdown.nvim#514

[sghng]

Can anyone share a screen recording or screenshot of what completions functioning actually look like? I assume that after typing [[ a popup of notes will occur for selection.

[jdlabelle]

Here you go

[neo451]

@sghng sorry for taking long to reply, I still don't have a definitive answer, but just some observations

1. you have a working blink.cmp, but checkhealth obsidian.nvim does not find it. It may have to do with how your config and runtimepaths are structured. Try just evaluate :=require"obsidian.api".get_plugin_info"blink.cmp" in your cmdline, if there's nothing, then you install path must be the issue.
2. about loading, obsidian.nvim calls blink.cmp's API to register a source, so in theory you should put blink.cmp in obsidian.nvim's dependencies field, but in reality you don't need any of them and lazy.nvim can just load them on require.
3. not being able to use the blink field in the render-markdown config also maybe hints that your blink installation is faulty, because render-markdown.nvim uses a similar structure as this plugin, and it registers a completion source, which caused issue for others, but you just not being able to set that up, maybe tells that other plugins can not use blink's API on your machine. Try reinstall blink as well.

[sghng]

Thanks for the reply. Here's my result from get_plugin_info:

I also went back to tinker with render-markdown completion, now the completion works with Blink as it should. Also tried comment out the line of enabling completion in render markdown, didn't solve it.

Tried reinstalling blink, didn't work either. Also tried remove anything from .local/share/nvim and reinitialize.

[patrykjadamczyk]

Sharing because maybe for someone that information will be useful.

For me blink completions didn't work because I only had blink_cmp = true and not nvim_cmp = false in configuration options.

I checked comments in here. And though I don't feel like that could be the answer in this case. If you don't explicitly disable nvim_cmp you could try to disable it and check if that would work for you.

Note for devs of this plugin:
Shouldn't this ifs be inverted (links refer to current newest commit for this file in main): lua/obsidian/init.lua:166-170 lua/obsidian/init.lua:91-95. Because currently if you have blink.cmp and blink.compat and you only enable blink then completion will not work because of defaults options that set nvim_cmp to true (because cmp module can be required).
What is kinda weird that even though config then I guess tries to use nvim_cmp. In healthcheck you still see blink.cmp in completion (which is because of how healthcheck works in this plugin but because of it is inconsistent with how config works).

Repro Init.lua

vim.env.LAZY_STDPATH = ".repro"
load(vim.fn.system "curl -s https://raw.githubusercontent.com/folke/lazy.nvim/main/bootstrap.lua")()

vim.fn.mkdir(".repro/vault", "p")

vim.o.conceallevel = 2

local plugins = {
  {
    "obsidian-nvim/obsidian.nvim",
    opts = {
      completion = {
        blink = true,
      },
      workspaces = {
        {
          name = "test",
          path = vim.fs.joinpath(vim.uv.cwd(), ".repro", "vault"),
        },
      },
    },
  },
  {
    'saghen/blink.compat',
    lazy = true,
    opts = {},
  },
  {
    "saghen/blink.cmp",
    opts = {
      fuzzy = { implementation = "lua" },
      keymap = {
        preset = "default",
      },
    },
  },
}

require("lazy.minit").repro { spec = plugins }

vim.cmd "checkhealth obsidian"

[neo451]

thank you for the feedback, the point about blink.compat being a problem is really true, I will refactor this.

[sghng]

thanks for pointing that out, however I just tried disabling nvim_cmp and it still doesn't work :(

[sghng]

The completion now works for me! Today when I was checking checkhealth blink.cmp, the 3 sources from obsidian obsidian, obsidian_tags, and obsidian_new showed up -- I've never seen them there before. I then added them to per_filetype sources for Markdown, then the completion starts to work!

[sghng]

@santoshkal @jakubdonovan did you observe these 3 completion sources in checkhealth blink.cmp?

[sghng]

The note completion works now, but this warning is emitted when doing completion:

[neo451]

the error is not directly from completion, but from footer module that updates on typing, in theory there should not be this error here, since I have limited the jobs spawn, but maybe that plus the completion's jobs is the issue.

Maybe I should introduce a global parallel jobs limit like lazy.nvim

before that, either raise the ulimit (or what is similar on your system), or just do

require"obsidian".setup{
   footer = { enabled = false },
}

[sghng]

Thanks to the investigation of the author of rendering-markdown, it seems that we found the root cause, please see his comment.

In short, it has to do with the way Blink handles per file type sources. If a per file type source is specified (in this case, render-markdown), Blink won't inherit default sources by default -- therefore the obsidian source is missing.

For future users looking at this thread, if you're not getting completion from Obsidian, make sure you change render-markdown completion to be through lsp instead of blink, as recommended by the author of render-markdown.