Option to bypass new note creation confirmation

[marchyman]

I will sometimes create a wiki-link to a new note then immediately attempt to open the new note. When doing this I find the "Create new note ..." dialog gets in the way. I realize some might like the dialog. A configuration option to bypass the dialog seems like a good idea.

Any comments?

[marchyman]

And this diff shows the local changes I made to implement this. I did not clone and issue a PR because I am quite the novice when it comes to lua/nvim and probably left something out.

diff --git a/lua/obsidian/api.lua b/lua/obsidian/api.lua
index c8284f2..f35fd99 100644
--- a/lua/obsidian/api.lua
+++ b/lua/obsidian/api.lua
@@ -638,7 +638,8 @@ M.follow_link = function(link, opts)
       or res.link_type == search.RefTypes.Markdown
     then
       -- Prompt to create a new note.
-      if M.confirm("Create new note '" .. res.location .. "'?") then
+      local ok = not Obsidian.opts.new_notes_confirmation
+      if ok or M.confirm("Create new note '" .. res.location .. "'?") then
         -- Create a new note.
         ---@type string|?, string[]
         local id, aliases
diff --git a/lua/obsidian/config.lua b/lua/obsidian/config.lua
index 36df0f9..12740e9 100644
--- a/lua/obsidian/config.lua
+++ b/lua/obsidian/config.lua
@@ -8,6 +8,7 @@ local config = {}
 ---@field notes_subdir? string
 ---@field templates? obsidian.config.TemplateOpts
 ---@field new_notes_location? obsidian.config.NewNotesLocation
+---@field new_notes_confirmation? boolean
 ---@field note_id_func? (fun(title: string|?, path: obsidian.Path|?): string)|?
 ---@field note_path_func? fun(spec: { id: string, dir: obsidian.Path, title: string|? }): string|obsidian.Path
 ---@field wiki_link_func? fun(opts: {path: string, label: string, id: string|?}): string
@@ -42,6 +43,7 @@ local config = {}
 ---@field notes_subdir string|?
 ---@field templates obsidian.config.TemplateOpts
 ---@field new_notes_location obsidian.config.NewNotesLocation
+---@field new_notes_confirmation? boolean
 ---@field note_id_func (fun(title: string|?, path: obsidian.Path|?): string)|?
 ---@field note_path_func (fun(spec: { id: string, dir: obsidian.Path, title: string|? }): string|obsidian.Path)|?
 ---@field wiki_link_func (fun(opts: {path: string, label: string, id: string|?}): string)
@@ -115,6 +117,7 @@ config.default = {
   log_level = vim.log.levels.INFO,
   notes_subdir = nil,
   new_notes_location = config.NewNotesLocation.current_dir,
+  new_notes_confirmation = true,
   note_id_func = require("obsidian.builtin").zettel_id,
   wiki_link_func = require("obsidian.builtin").wiki_link_id_prefix,
   markdown_link_func = require("obsidian.builtin").markdown_link,

[neo451]

I agree one should be able to skip this confirmation, but exactly we can think more. Some of this is also just writing down ideas for future reference.
I for now don't want to add new options in the "top level", they seem a bit too random and users might miss it or just not realize they have this option, ideally most options should be grouped like opts.completion.create_new. But exactly which module this option belongs to is up for debate.
another idea I have been exploring is the idea of builtin functions. https://github.com/obsidian-nvim/obsidian.nvim/blob/main/lua/obsidian/builtin.lua

These functions are not directly referenced in the codebase, but indirectly used, for example img_text_func defines how a image link is formatted, but in code, we Obsidian.attachments.img_text_func, which defaults to the above function, but user can overrride this function, with their own logic, either add a condition before calling the builtin one, or do their own completely.

So ideally follow_link_func can be added, but the trait of these builtin functions is that they are pretty settled and atomic logic, but follow_link now is a bit too verbose, and I will be simplifying it in the future, once that is done, we can allow this overriding.

The final result should be that, opts.follow_link_func defaults to builtin.follow_link, but follow_link will also accept a new filed confirm in opts, and then you can do:

require"obsidian".setup{
   follow_link_func = function(link, opts)
          opts.confirm = false
          require"obsidian.builtin".follow_link(link, opts)
   end,
}