Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]memory leak during parser and parser improvement #308

Open
AMOSOMNUM opened this issue Oct 25, 2023 · 1 comment
Open

[BUG]memory leak during parser and parser improvement #308

AMOSOMNUM opened this issue Oct 25, 2023 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@AMOSOMNUM
Copy link

All happen in src/observer/sql/parser/yacc.sql.y.

  1. memory leak

Line 374-value:
$1 should be freed.

Line 402-update_stmt:
$6 should be deleted.

  1. parser improvement
    use left recursion for better performance and remove silly vector reverse!!!
@AMOSOMNUM AMOSOMNUM added the bug Something isn't working label Oct 25, 2023
@hnwyllmm
Copy link
Collaborator

Thanks for you advices.

@hnwyllmm hnwyllmm added the good first issue Good for newcomers label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hnwyllmm @AMOSOMNUM