Skip to content

Commit 32e159a

Browse files
simplify away ppx_let test which causes failures
1 parent 2d5c9d4 commit 32e159a

File tree

5 files changed

+5
-48
lines changed

5 files changed

+5
-48
lines changed

.github/workflows/workflow.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ jobs:
9191

9292
- run: opam install lwt_react lwt --deps-only --with-test
9393

94-
- run: opam install lwt_ppx lwt_ppx_let --deps-only --with-test
94+
- run: opam install lwt_ppx --deps-only --with-test
9595
if: ${{ matrix.ppx == true }}
9696

9797
- run: opam exec -- dune build --only-packages lwt_react,lwt
@@ -104,9 +104,6 @@ jobs:
104104
- run: opam exec -- dune runtest --only-packages lwt_ppx
105105
if: ${{ matrix.ppx == true }}
106106

107-
- run: opam exec -- make ppx_let-test
108-
if: ${{ matrix.ppx == true }}
109-
110107
lint-opam:
111108
runs-on: ubuntu-latest
112109

dune-project

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,6 @@
1212
(source (github ocsigen/lwt))
1313
(documentation "https://ocsigen.org/lwt")
1414

15-
(package
16-
(name lwt_ppx_let)
17-
(synopsis "Dummy package context for ppx_let tests")
18-
(description "Internal package used to partition ppx_let tests.")
19-
(depends
20-
(ocaml (>= 4.08))
21-
(ppx_let :with-test)
22-
lwt))
23-
2415
(package
2516
(name lwt_ppx)
2617
(synopsis "PPX syntax for Lwt, providing something similar to async/await from JavaScript")
@@ -56,5 +47,6 @@ synchronization primitives. Code can be run in parallel on an opt-in basis.
5647
(ocamlfind (and :dev (>= 1.7.3-1)))
5748
(odoc (and :with-doc (>= 2.3.0)))
5849
dune-configurator
59-
ocplib-endian)
50+
ocplib-endian
51+
(ppx_let :with-test))
6052
(depopts base-threads base-unix conf-libev))

lwt.opam

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ depends: [
2727
"odoc" {with-doc & >= "2.3.0"}
2828
"dune-configurator"
2929
"ocplib-endian"
30+
"ppx_let" {with-test}
3031
]
3132
depopts: ["base-threads" "base-unix" "conf-libev"]
3233
dev-repo: "git+https://github.com/ocsigen/lwt.git"

lwt_ppx_let.opam

Lines changed: 0 additions & 33 deletions
This file was deleted.

test/ppx_let/dune

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@
55

66
(rule
77
(alias runtest)
8-
(package lwt_ppx_let)
8+
(package lwt)
99
(action (run %{exe:test.exe})))

0 commit comments

Comments
 (0)