Skip to content

Commit

Permalink
simplify away ppx_let test which causes failures
Browse files Browse the repository at this point in the history
  • Loading branch information
raphael-proust committed Oct 25, 2024
1 parent 2d5c9d4 commit 32e159a
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 48 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ jobs:

- run: opam install lwt_react lwt --deps-only --with-test

- run: opam install lwt_ppx lwt_ppx_let --deps-only --with-test
- run: opam install lwt_ppx --deps-only --with-test
if: ${{ matrix.ppx == true }}

- run: opam exec -- dune build --only-packages lwt_react,lwt
Expand All @@ -104,9 +104,6 @@ jobs:
- run: opam exec -- dune runtest --only-packages lwt_ppx
if: ${{ matrix.ppx == true }}

- run: opam exec -- make ppx_let-test
if: ${{ matrix.ppx == true }}

lint-opam:
runs-on: ubuntu-latest

Expand Down
12 changes: 2 additions & 10 deletions dune-project
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,6 @@
(source (github ocsigen/lwt))
(documentation "https://ocsigen.org/lwt")

(package
(name lwt_ppx_let)
(synopsis "Dummy package context for ppx_let tests")
(description "Internal package used to partition ppx_let tests.")
(depends
(ocaml (>= 4.08))
(ppx_let :with-test)
lwt))

(package
(name lwt_ppx)
(synopsis "PPX syntax for Lwt, providing something similar to async/await from JavaScript")
Expand Down Expand Up @@ -56,5 +47,6 @@ synchronization primitives. Code can be run in parallel on an opt-in basis.
(ocamlfind (and :dev (>= 1.7.3-1)))
(odoc (and :with-doc (>= 2.3.0)))
dune-configurator
ocplib-endian)
ocplib-endian
(ppx_let :with-test))
(depopts base-threads base-unix conf-libev))
1 change: 1 addition & 0 deletions lwt.opam
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ depends: [
"odoc" {with-doc & >= "2.3.0"}
"dune-configurator"
"ocplib-endian"
"ppx_let" {with-test}
]
depopts: ["base-threads" "base-unix" "conf-libev"]
dev-repo: "git+https://github.com/ocsigen/lwt.git"
Expand Down
33 changes: 0 additions & 33 deletions lwt_ppx_let.opam

This file was deleted.

2 changes: 1 addition & 1 deletion test/ppx_let/dune
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@

(rule
(alias runtest)
(package lwt_ppx_let)
(package lwt)
(action (run %{exe:test.exe})))

0 comments on commit 32e159a

Please sign in to comment.