Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: refine the logging strategy #103

Open
albertotirla opened this issue Mar 10, 2023 · 0 comments
Open

UX: refine the logging strategy #103

albertotirla opened this issue Mar 10, 2023 · 0 comments
Assignees
Labels
Bin Improvements to the binary program. enhancement New feature or request
Milestone

Comments

@albertotirla
Copy link
Member

albertotirla commented Mar 10, 2023

as you probably noticed already, odilia reads text from the terminal, even if it's not in focus when that happens. Most times though, it's trying to read its own logs. Since odilia starts with log level set to debug and all of it is redirected to stdout, also because all speech is being done in odilia by interrupting the previous utterance, odilia will basically not even be able to read those logs, nor anything else on the screen. To fix that, roughly the following things have to happen:

  • the log level option in the config file has to be used, currently it's only read
    if the log level is not present, the program will print a warning to stderr and assume info
  • there will be a new option in the config file, log_file_path, which would be used to direct the logs to.
    Of course, the user must have permission to access that location, otherwise the program will just bale
    If said option doesn't exist, logs will be sent to stdout

Aside from keeping a fairly spam free terminal, this has the benefit of making it easier to submit bug reports, by setting log level to debug(now in the config file but in the future probably in a gui), and just attaching the file to an issue, nice and clean

@albertotirla albertotirla added this to the 0.1.0 milestone Mar 10, 2023
@albertotirla albertotirla self-assigned this Mar 10, 2023
@albertotirla albertotirla added enhancement New feature or request Bin Improvements to the binary program. labels Mar 10, 2023
@TTWNO TTWNO modified the milestones: 0.1.0, 0.2.0 Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bin Improvements to the binary program. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants