[FIX/PERF] Charts: fix loop condition

rrahir · rrahir · commit 3cd084c3503e · 2025-03-26T11:48:29.000Z
The "getChartLabelValues" helper would refetch all the chart data at each iteration of a loop for no reason. closes #6028 Task: 4675166 X-original-commit: 8b3aed3 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com> Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
diff --git a/src/helpers/figures/charts/chart_ui_common.ts b/src/helpers/figures/charts/chart_ui_common.ts
@@ -215,7 +215,8 @@ export function getChartLabelValues(
       };
     }
   } else if (dataSets.length === 1) {
-    for (let i = 0; i < getData(getters, dataSets[0]).length; i++) {
+    const dataLength = getData(getters, dataSets[0]).length;
+    for (let i = 0; i < dataLength; i++) {
       labels.formattedValues.push("");
       labels.values.push("");
     }

Original file line number	Diff line number	Diff line change
`@@ -215,7 +215,8 @@ export function getChartLabelValues(`
`215`	`215`	`};`
`216`	`216`	`}`
`217`	`217`	`} else if (dataSets.length === 1) {`
`218`		`- for (let i = 0; i < getData(getters, dataSets[0]).length; i++) {`
	`218`	`+ const dataLength = getData(getters, dataSets[0]).length;`
	`219`	`+ for (let i = 0; i < dataLength; i++) {`
`219`	`220`	`labels.formattedValues.push("");`
`220`	`221`	`labels.values.push("");`
`221`	`222`	`}`