[FIX] clipboard: wrong clipboard invalidation

The CUT clipboard should be invalidated when inserting rows inside
of the CUT zone.

But we didn't check the sheet where the rows are
inserted, so the clipboard was invalidating when inserting rows inside
another sheet.

closes #4237

Task: 3901961
X-original-commit: cfb3a65
Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
Signed-off-by: Adrien Minne (adrm) <[email protected]>

Author: hokolomopo

src/plugins/ui_stateful/clipboard.ts

@@ -210,7 +210,7 @@ export class ClipboardPlugin extends UIPlugin {
         this.status = "invisible";
 
         // If we add a col/row inside or before the cut area, we invalidate the clipboard
-        if (this._isCutOperation !== true) {
+        if (this._isCutOperation !== true || cmd.sheetId !== this.copiedData?.sheetId) {
           return;
         }
         const isClipboardDirty = this.isColRowDirtyingClipboard(
@@ -226,7 +226,7 @@ export class ClipboardPlugin extends UIPlugin {
         this.status = "invisible";
 
         // If we remove a col/row inside or before the cut area, we invalidate the clipboard
-        if (this._isCutOperation !== true) {
+        if (this._isCutOperation !== true || cmd.sheetId !== this.copiedData?.sheetId) {
           return;
         }
         for (let el of cmd.elements) {

tests/clipboard/clipboard_plugin.test.ts

@@ -2188,6 +2188,20 @@ describe("clipboard: pasting outside of sheet", () => {
       expect(getCellContent(model, "C1")).toBe("");
       expect(getCellContent(model, "C3")).toBe("");
     });
+
+    test("Adding rows in another sheet does not invalidate the clipboard", () => {
+      const model = new Model();
+      setCellContent(model, "A1", "1");
+      setCellContent(model, "A2", "2");
+      cut(model, "A1:A2");
+
+      createSheet(model, { activate: true });
+      addRows(model, "after", 0, 5);
+
+      paste(model, "A1");
+      expect(getCellContent(model, "A1")).toBe("1");
+      expect(getCellContent(model, "A2")).toBe("2");
+    });
   });
 
   describe("remove col/row can invalidate the clipboard of cut", () => {
@@ -2270,5 +2284,19 @@ describe("clipboard: pasting outside of sheet", () => {
       expect(getCellContent(model, "B2")).toBe("1");
       expect(getCellContent(model, "D1")).toBe("");
     });
+
+    test("Removing rows in another sheet does not invalidate the clipboard", () => {
+      const model = new Model();
+      setCellContent(model, "A1", "1");
+      setCellContent(model, "A2", "2");
+      cut(model, "A1:A2");
+
+      createSheet(model, { activate: true });
+      deleteRows(model, [1]);
+
+      paste(model, "A1");
+      expect(getCellContent(model, "A1")).toBe("1");
+      expect(getCellContent(model, "A2")).toBe("2");
+    });
   });
 });