[FIX] forwardport: avoid double counting PRs for teams

In the case where both author and reviewer of a PR have the same
team (which is very common e.g. self review or a team member approving
your PR) then the `outstanding_per_group` entry would be incremented
twice, leading to overcounting outstanding forward ports for the team.

Fixes #801

Author: xmo-odoo

forwardport/controllers.py

@@ -79,10 +79,12 @@ def outstanding(self, partner=0, authors=True, reviewers=True, group=0):
             })
             if authors:
                 outstanding_per_author[source.author] += len(prs)
-                outstanding_per_group[source.author.commercial_partner_id] += len(prs)
-            if reviewers and source:
+            if reviewers:
                 outstanding_per_reviewer[source.reviewed_by] += len(prs)
-                outstanding_per_group[source.reviewed_by.commercial_partner_id] += len(prs)
+
+            # if both the source and reviewer have the same team, don't count the PRs twice
+            for team in source.author.commercial_partner_id | source.reviewed_by.commercial_partner_id:
+                outstanding_per_group[team] += len(prs)
 
         culprits = Partners.browse(p.id for p, _ in (outstanding_per_reviewer + outstanding_per_author).most_common())
         return request.render('forwardport.outstanding', {