Validate model in remove model

[niboo-ave]

Hello,

I don't understand the need to validate a model before it removal. (

upgrade-util/src/util/models.py

Line 73 in 6c9a30c

_validate_model(model)

)

I have the case where an other partner did a poor job at naming model (_name is "file_wizard") and I can't properly use the remove model ( I actually remove the full module but doesn't change much).

Currently i just commented the validate line on my local, but would be nice if we could use this in production.

Any explanation of the why this validation is required at removal is welkom, any other solution/work around is more than welkom.

Best Regards,

[aj-fuentes]

any other solution/work around is more than welkom.

Just use the environment variable UPG_VALID_MODELS, example: UPG_VALID_MODELS='my_model1;my_model2;other_model'
Ref:

upgrade-util/src/util/helpers.py

Line 26 in 6c9a30c

| {m.strip() for m in os.getenv("UPG_VALID_MODELS", "").split(";")} - {""}

Any explanation of the why this validation is required at removal is welkom

It's a very common error to use a table name instead of the model name. Since this util won't fail if the model is not found the author may never notice their mistake until it's too late.