Merged
Conversation
Member
Author
|
@maurerle: Before I start with docs and tests, what do you think? |
Use of timeindex.freq.delta is deprecated.
maurerle
approved these changes
Apr 8, 2025
Contributor
maurerle
left a comment
There was a problem hiding this comment.
I did not spend too much time with this yet, so far it looks good.
The new API allows to create BDEW profiles from arbitrary timeindex length - which is nice!
And makes totally sense, given the shape of the new data.
On the other hand, it does not allow to integrate the new profiles easily into the existing API, so
e_slp.get_profiles('h0').head()
e_slp.get_profiles('h25').head()
does not work easily..
But it might be enough to somehow also provide functions which give:
bdew.H25(index15m)
bdew.H0(index15m)
and only "use" new API, which would require some tinkering for handling time indices from different years, but seems the best approach on the long run..?
This is a performance optimisation. The values where not changed anyway.
Member
Author
|
Everything implemented, 100 % coverage. If nobody objects, I'll merge this tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add BDEW profiles released in 2025 including new, more modular structure as discussed in #77.
Changes with respect to the API for SLP 2000:
0.02 * H25(time_index)to have a H25 SLP for 20 MWh/a.)Closes #77