Skip to content

Commit 13ab4a3

Browse files
committed
fabtests/benchmark_shared: bandwidth_rma: force sync after each warmup iteration
Modify bandwidth_rma() to synchronize after every warmup iteration instead of only at window boundaries. This ensures proper warmup of the server->client connection path for unidirectinal mode The writedata test asymmetry (client sends many writes, server replies with single send per window) means only the client->server path gets warmed up during normal iterations. Forcing sync during warmup ensures both directions are properly established before timing begins. Also increase default warmup iterations from 10 to 16. Signed-off-by: Alexey Novikov <[email protected]>
1 parent e60a8d2 commit 13ab4a3

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

fabtests/benchmarks/benchmark_shared.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -767,7 +767,7 @@ int bandwidth_rma(enum ft_rma_opcodes rma_op, struct fi_rma_iov *remote)
767767
if (ret)
768768
return ret;
769769

770-
if (++j == opts.window_size) {
770+
if (++j == opts.window_size || i < opts.warmup_iterations) {
771771
ret = bw_rma_comp(rma_op, j);
772772
if (ret)
773773
return ret;

fabtests/include/shared.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,7 @@ extern char default_port[8];
314314
#define INIT_OPTS (struct ft_opts) \
315315
{ .options = FT_OPT_RX_CQ | FT_OPT_TX_CQ, \
316316
.iterations = 1000, \
317-
.warmup_iterations = 10, \
317+
.warmup_iterations = 16, \
318318
.num_connections = 1, \
319319
.transfer_size = 1024, \
320320
.window_size = 64, \

0 commit comments

Comments
 (0)