[v2.3.x] fabtests/multi_ep: fix fi_info usage

In the RDM case of the multi_ep test, the test calls fi_getinfo again
for each EP in order to override the source address.
The source address was getting set as the node for the new call but the
FI_SOURCE flag was not set meaning the local source address was getting
resolved into the dst_addr which was never used anyway.
This removes the node parameter with the source address to let the
provider set a source address for us.

This also fixes an issue on cleanup if one of the calls to getinfo fails,
the test would try to cleanup the resources and would segfault because
the fi is NULL.

Signed-off-by: Alexia Ingerson <[email protected]>
(cherry picked from commit 1a749cb)

Author: aingerson

fabtests/functional/multi_ep.c

@@ -72,6 +72,9 @@ static void free_ep_res()
 	int i;
 
 	for (i = 0; i < num_eps; i++) {
+		if (!fi)
+			continue;
+
 		if (fi->domain_attr->mr_mode & FI_MR_RAW)
 			(void) fi_mr_unmap_key(domain, peer_iovs[i].key);
 
@@ -473,7 +476,7 @@ static int setup_av_ep(int idx)
 	hints->src_addr = NULL;
 	hints->src_addrlen = 0;
 
-	ret = fi_getinfo(FT_FIVERSION, opts.src_addr, NULL, 0, hints, &fi);
+	ret = fi_getinfo(FT_FIVERSION, NULL, NULL, 0, hints, &fi);
 	if (ret) {
 		FT_PRINTERR("fi_getinfo", ret);
 		return ret;