Skip to content

Commit 87320db

Browse files
committed
[v2.2.x] prov/psm3: Suppress "this statement may fall through" warning
Compiler warning: ``` ../prov/psm3/psm3/ptl_ips/ips_proto_connect.c: In function ‘ips_proto_build_connect_message’: ../prov/psm3/psm3/ptl_ips/ips_proto_connect.c:950:6: warning: this statement may fall through [-Wimplicit-fallthrough=] if (! force) ^ ../prov/psm3/psm3/ptl_ips/ips_proto_connect.c:953:2: note: here case OPCODE_DISCONNECT_REPLY: ^~~~ ``` gcc can identify intentional fallthrough via comment, but the original comment has an extra 'S'. There are other approaches to address the same issue. However, none of those are univerally supported. Here we just take the simplest fix by removing the extra 'S' in the comment. Signed-off-by: Jianxin Xiong <[email protected]>
1 parent aac0bec commit 87320db

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

prov/psm3/psm3/ptl_ips/ips_proto_connect.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -949,7 +949,7 @@ ips_proto_build_connect_message(struct ips_proto *proto,
949949
case OPCODE_DISCONNECT_REQUEST:
950950
if (! force)
951951
hdr->connidx |= IPS_DISCONNECT_NOFORCE;
952-
/* FALLSTHROUGH */
952+
/* FALLTHROUGH */
953953
case OPCODE_DISCONNECT_REPLY:
954954
paylen = sizeof(struct ips_connect_hdr);
955955
// placeholder, typically ips_connect_hdr is sufficient

0 commit comments

Comments
 (0)