Skip to content

Commit 8b8e568

Browse files
committed
fabtests/efa: Enable sread tests for efa fabric
Signed-off-by: Darryl Abbate <[email protected]>
1 parent 79cc073 commit 8b8e568

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

fabtests/pytest/efa/test_rdm.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,12 +162,16 @@ def test_rdm_bw_zcpy_recv_use_fi_more(cmdline_args, memory_type, zcpy_recv_max_m
162162

163163
@pytest.mark.functional
164164
@pytest.mark.parametrize("comp_method", ["sread", "fd"])
165-
def test_rdm_pingpong_sread(cmdline_args, completion_semantic, memory_type_bi_dir, direct_message_size, support_sread, comp_method):
165+
@pytest.mark.parametrize("fabric", ["efa", "efa-direct"])
166+
def test_rdm_pingpong_sread(cmdline_args, completion_semantic, memory_type_bi_dir,
167+
direct_message_size, support_sread, comp_method, fabric):
166168
if not support_sread:
167169
pytest.skip("sread not supported by efa device.")
170+
if fabric == "efa" and comp_method == "sread" and completion_semantic == "delivery_complete":
171+
pytest.skip("Skip delivery-complete with sread to avoid manual-progress deadlock.")
168172
efa_run_client_server_test(cmdline_args, f"fi_rdm_pingpong -c {comp_method}", "short",
169173
completion_semantic, memory_type_bi_dir,
170-
direct_message_size, fabric="efa-direct")
174+
direct_message_size if fabric == "efa-direct" else "all", fabric=fabric)
171175

172176

173177
# These tests skip efa-direct because efa-direct does not

fabtests/pytest/efa/test_rma_bw.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,12 +91,12 @@ def test_rma_bw_sread(cmdline_args, rma_operation_type, rma_bw_completion_semant
9191
direct_rma_size, rma_bw_memory_type, support_sread, comp_method, rma_fabric):
9292
if not support_sread:
9393
pytest.skip("sread not supported by efa device.")
94-
if rma_fabric == "efa":
95-
pytest.skip("sread not implemented in efa fabric yet.")
94+
if rma_fabric == "efa" and comp_method == "sread" and rma_bw_completion_semantic == "delivery_complete":
95+
pytest.skip("Skip delivery-complete with sread to avoid manual-progress deadlock.")
9696
command = f"fi_rma_bw -e rdm -c {comp_method}"
9797
command = command + " -o " + rma_operation_type
9898
# rma_bw test with data verification takes longer to finish
9999
timeout = max(1080, cmdline_args.timeout)
100100
efa_run_client_server_test(cmdline_args, command, "short", rma_bw_completion_semantic,
101-
rma_bw_memory_type, direct_rma_size,
101+
rma_bw_memory_type, direct_rma_size if rma_fabric == "efa-direct" else "all",
102102
timeout=timeout, fabric=rma_fabric)

0 commit comments

Comments
 (0)