[v2.1.x] prov/opx: Adding changes to resolve Coverity Scan Defects

-Fix for Coverity Defect 456943 - moving unnecessary null check before dereference
-Fix for Coverity Defect 456942 - add harsher case than assert to prevent possible negative array indexing
-Fix for Coverity Defect 456941 - moving null check before dereference
-Fix for Coverity Defect 456939 - moving null check before first dereference
-Fix for Coverity Defect 456938 - adding null check
-Fix for Coverity Defect 454699 - add missing free statement to err case

Signed-off-by: Garrett Weil <[email protected]>
(cherry picked from commit 9e4315f)

Author: gwcornelis

prov/opx/include/rdma/opx/fi_opx_reliability.h

@@ -767,7 +767,9 @@ struct fi_opx_reliability_flow *fi_opx_reliability_create_rx_flow(struct fi_opx_
 
 	if (OFI_UNLIKELY(rbt_rc != RBT_STATUS_OK)) {
 		void *itr = fi_opx_rbt_find(state->rx_flow_rbtree, (void *) key);
-		rbtErase(state->rx_flow_rbtree, itr);
+		if (itr) {
+			rbtErase(state->rx_flow_rbtree, itr);
+		}
 		free(flow);
 		FI_WARN(fi_opx_global.prov, FI_LOG_EP_DATA,
 			"Error creating RX Flow: Could not insert flow into rx.flow, rbtInsert() returned %d\n",

prov/opx/src/fi_opx_domain.c

@@ -197,13 +197,13 @@ int fi_opx_choose_domain(uint64_t caps, struct fi_domain_attr *domain_attr, stru
 	domain_attr->mr_mode |= FI_MR_HMEM;
 #endif
 
-	if (hints->mr_mode & FI_MR_VIRT_ADDR) {
-		FI_INFO(fi_opx_global.prov, FI_LOG_DOMAIN,
-			"Application requests FI_MR_VIRT_ADDR, OPX is turning on that mr_mode bit\n");
-		domain_attr->mr_mode |= FI_MR_VIRT_ADDR;
-	}
-
 	if (hints) {
+		if (hints->mr_mode & FI_MR_VIRT_ADDR) {
+			FI_INFO(fi_opx_global.prov, FI_LOG_DOMAIN,
+				"Application requests FI_MR_VIRT_ADDR, OPX is turning on that mr_mode bit\n");
+			domain_attr->mr_mode |= FI_MR_VIRT_ADDR;
+		}
+
 		if (hints->domain) {
 			struct fi_opx_domain *opx_domain =
 				container_of(hints->domain, struct fi_opx_domain, domain_fid);

prov/opx/src/fi_opx_ep.c

@@ -2273,7 +2273,7 @@ int fi_opx_check_tx_attr(struct fi_tx_attr *tx_attr, uint64_t hinted_caps)
 		goto err;
 	}
 
-	if ((tx_attr) && ((tx_attr->caps | hinted_caps) != hinted_caps)) {
+	if ((tx_attr->caps | hinted_caps) != hinted_caps) {
 		FI_DBG_TRACE(
 			fi_opx_global.prov, FI_LOG_EP_DATA,
 			"info->tx_attr->caps = 0x%016lx, info->caps = 0x%016lx, (info->tx_attr->caps | info->caps) = 0x%016lx, ((info->tx_attr->caps | info->caps) ^ info->caps) = 0x%016lx\n",

prov/opx/src/fi_opx_sep.c

@@ -358,11 +358,15 @@ static int fi_opx_rx_ctx(struct fid_ep *sep, int index, struct fi_rx_attr *attr,
 	if (info.tx_attr) {
 		free(info.tx_attr);
 	}
+	if (info.rx_attr) {
+		free(info.rx_attr);
+	}
 
 	info.fabric_attr = NULL;
 	info.domain_attr = NULL;
 	info.ep_attr	 = NULL;
 	info.tx_attr	 = NULL;
+	info.rx_attr	 = NULL;
 
 	return -errno;
 }

prov/opx/src/opa_proto.c

@@ -6,7 +6,7 @@
   GPL LICENSE SUMMARY
 
   Copyright(c) 2015 Intel Corporation.
-  Copyright(C) 2021-2024 Cornelis Networks.
+  Copyright(C) 2021-2025 Cornelis Networks.
 
   This program is free software; you can redistribute it and/or modify
   it under the terms of version 2 of the GNU General Public License as
@@ -200,6 +200,9 @@ int opx_map_hfi_mem(int fd, struct _hfi_ctrl *ctrl, size_t subctxt_cnt, __u64 *r
 
 	/* 10. Map the RHEQ page (JKR only) */
 	sz = sizeof(uint64_t) * (size_t) cinfo->rcvhdrq_cnt;
+	if (!rheq) { /* should never happen */
+		return -1;
+	}
 	_HFI_PDBG("ctx %#hx, subctxt_cnt %#lx, rheq %#llX, fd %d, sz %zu/%zu\n", cinfo->ctxt, subctxt_cnt, *rheq, fd,
 		  sz, (size_t) cinfo->rcvhdrq_cnt);
 	errno = 0;
@@ -357,13 +360,12 @@ int opx_map_hfi_mem(int fd, struct _hfi_ctrl *ctrl, size_t subctxt_cnt, __u64 *r
 
 err_mmap_subctxt_rcvhdrbuf:
 	/* if we got it here, subctxt_cnt must be != 0 */
-	HFI_MUNMAP_ERRCHECK(binfo, subctxt_uregbase, arrsz[SUBCTXT_UREGBASE]);
-
-err_mmap_subctxt_rheq:
-	/* New field, special handling */
 	if (rheq && *rheq) {
-		HFI_MUNMAP((void *) *rheq, sizeof(uint64_t) * (size_t) cinfo->rcvhdrq_cnt);
+		HFI_MUNMAP_ERRCHECK(binfo, subctxt_uregbase, arrsz[SUBCTXT_UREGBASE]);
 	}
+err_mmap_subctxt_rheq:
+	/* New field, special handling */
+	HFI_MUNMAP((void *) *rheq, sizeof(uint64_t) * (size_t) cinfo->rcvhdrq_cnt);
 
 err_mmap_subctxt_uregbase:
 	HFI_MUNMAP_ERRCHECK(binfo, status_bufbase, arrsz[STATUS_BUFBASE]);