Skip to content

Commit cfaac7a

Browse files
committed
prov/cxi: reset timer on rx of ARM packet
We were not (re)setting the timer for the "need to re-arm" logic on the leaf side. This resulted in a performance blip when the timer eventually expired. We now reset this timer as soon as the leaf sees an ARM packet. Signed-off-by: John Heemstra <[email protected]>
1 parent 46d451b commit cfaac7a

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

prov/cxi/src/cxip_coll.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,8 @@
5454
#define MAGIC 0x677d
5555
#define TIMER_UNSET -1
5656

57+
static inline void _set_arm_expires(struct cxip_coll_reduction *reduction);
58+
5759
/****************************************************************************
5860
* Metrics for evaluating collectives
5961
*/
@@ -1061,6 +1063,7 @@ static void _coll_rx_progress(struct cxip_req *req,
10611063
if (pkt->hdr.seqno == CXIP_COLL_MOD_SEQNO) {
10621064
TRACE_PKT("pre-rearm pkt dropped\n");
10631065
CXIP_INFO("pre-rearm pkt dropped\n");
1066+
_set_arm_expires(reduction);
10641067
return;
10651068
}
10661069

0 commit comments

Comments
 (0)