Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove test files to reduce gem size #951

Open
ybiquitous opened this issue Jan 14, 2025 · 1 comment · Fixed by #952
Open

Remove test files to reduce gem size #951

ybiquitous opened this issue Jan 14, 2025 · 1 comment · Fixed by #952

Comments

@ybiquitous
Copy link

Hello. I found that the current published oj gems have included test files, regardless of PR #771.

Do you have any reasons to keep test files in the published gems? Otherwise, do you think it makes sense to remove them?

For your information, I could save about 67KB in my local environment by this gemspec change:

-  s.files = Dir['{lib,ext,test}/**/*.{rb,h,c}'] + ['LICENSE', 'README.md', 'CHANGELOG.md', 'RELEASE_NOTES.md'] + Dir['pages/*.md']
+  s.files = Dir['{lib,ext}/**/*.{rb,h,c}'] + ['LICENSE', 'README.md', 'CHANGELOG.md', 'RELEASE_NOTES.md'] + Dir['pages/*.md']
$ /bin/ls -hl oj-3.16.9.gem*
-rw-r--r--@ 1 masafumi.koba  staff   188K Jan 14 14:43 oj-3.16.9.gem
-rw-r--r--@ 1 masafumi.koba  staff   255K Jan 14 14:30 oj-3.16.9.gem.orig

If you'd like to reject the suggestion, please feel free to close this issue.
Thank you.
@Watson1978
Copy link
Collaborator

Thanks. Can you send a Pull Request?

ybiquitous added a commit to ybiquitous/oj that referenced this issue Jan 14, 2025
@ybiquitous
Remove test files to reduce gem size
b4cdf9d 
Closes ohler55#951
Follows up to ohler55#771

This aims to reduce the gem package size by removing test files from a built gem.
@ybiquitous ybiquitous mentioned this issue Jan 14, 2025
Merged
pull bot pushed a commit to admariner/oj that referenced this issue Jan 14, 2025
@ybiquitous
Remove test files to reduce gem size (ohler55#952)
5272aa7 
Closes ohler55#951
Follows up to ohler55#771

This aims to reduce the gem package size by removing test files from a built gem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove test files to reduce gem size ybiquitous/oj
2 participants
@Watson1978 @ybiquitous