Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probably unneeded parameters in suite2p_file nodes #613

Open
milesOIST opened this issue Dec 12, 2023 · 0 comments
Open

Probably unneeded parameters in suite2p_file nodes #613

milesOIST opened this issue Dec 12, 2023 · 0 comments
Labels
backend For backendapp tasks enhancement New feature or request

Comments

@milesOIST
Copy link
Collaborator

milesOIST commented Dec 12, 2023

追加機能についての概要
suite2p_file_convert

  • do_registration: suite2p_file_convert and suite2p_registration are separate nodes. So we don't need this parameter.

  • keep_movie_raw: I think Optinist always keeps this. Does this option have a meaning? This is necessary for two_step_registration, but we don't give that parameter to users.

  • reg_tif: "whether or not to write the registered binary to tiff files". This also seems an inherent Optinist decision, does the user have access to there?

suite2p_registration

  • functional_chan: This should be moved to suite2p_file_convert.

  • do_bidiphase: This could be set to the same as bidi_corrected. do_bidiphase is only asking whether to do the calculation. However, bidi_corrected decides whether to apply this. For Optinist we only need to do the calculation if we are going to apply it.

Consider also putting bidi_corrected and bidiphase under suite2p_file_convert as these are suite2p "main settings"

  • frames_include: Optinist really needs it's own node to modify the frames/pixels/rows to include in any file type.

  • diameter: This seems to only be used in Cellpose Detection, which is an extended toolbox that I don't think Optinist is using.

suite2p_roi

  • neucoeff: this may only be used in suite2p_spike_deconv. It seems to be a repeated input parameter in both suite2p_roi and suite2p_spike_deconv.

Consider moving tau under suite2p_file_convert as these are suite2p "main settings".

重要度
低: この機能は開発要件の最低条件に含まれていない。

@milesOIST milesOIST added enhancement New feature or request frontend For frontend app tasks labels Dec 12, 2023
@milesOIST milesOIST changed the title Probably unneeded parameter suite2p_file_convert do_registration Probably unneeded parameters in suite2p_file_convert Dec 12, 2023
@milesOIST milesOIST changed the title Probably unneeded parameters in suite2p_file_convert Probably unneeded parameters in suite2p_file nodes Dec 12, 2023
@ReiHashimoto ReiHashimoto added backend For backendapp tasks and removed frontend For frontend app tasks labels Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend For backendapp tasks enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants