Fix code scanning alert - Unvalidated dynamic method call in insert_monuments.py

[Copilot]

Summary

This PR fixes CodeQL code scanning alert #1: "Unvalidated dynamic method call" in tools/insert_monuments.py.

Issue

The code was using a dynamic dictionary key assignment pattern that CodeQL flagged as a security vulnerability:

for var_name, key in fields.items():
    value = data.get(key, None)
    if key in ['Schutzumfang', 'Begründung'] and isinstance(value, list):
        value = json.dumps(value)
    variables[var_name] = value  # ← Unvalidated dynamic key assignment

This pattern is problematic because var_name is dynamically determined from iteration, which could potentially be exploited if the fields dictionary were manipulated.

Solution

Refactored the code to directly extract values from the data dictionary without using an intermediate dictionary with dynamic keys:

# Extract values directly from data dictionary
address_location = data.get('Adresse-Lage', None)
description = data.get('Beschreibung', None)
designation = data.get('Bezeichnung', None)
monument_type = data.get('Kulturdenkmaltyp', None)

protection_scope = data.get('Schutzumfang', None)
if isinstance(protection_scope, list):
    protection_scope = json.dumps(protection_scope)

# ... and so on for all fields

Benefits

• ✅ Eliminates the security vulnerability flagged by CodeQL
• ✅ Simplifies the code by removing unnecessary intermediate dictionary
• ✅ Makes the code more explicit and easier to understand
• ✅ Maintains exact same functionality (all logic preserved)
• ✅ Reduces code by 12 lines

Testing

• Python syntax validation: ✅ Passed
• Functionality verification: ✅ All variable assignments remain identical to original implementation

Closes #1

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Fix code scanning alert - Unvalidated dynamic method call</issue_title>
<issue_description>

Tracking issue for:

• https://github.com/oklabflensburg/open-monuments-map/security/code-scanning/1
  </issue_description>

<agent_instructions>fix issue</agent_instructions>

Comments on the Issue (you are @copilot in this section)

Fixes #2

---

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.