Potential enhancements for persisted.save()
#160
Replies: 1 comment 1 reply
-
Thanks for your comments and taking the time to read the plugin's code as well. Regarding 1), that is a very good point as that's hugely undesirable. I'll post a fix later today Regarding 2), |
Beta Was this translation helpful? Give feedback.
-
nvim
is executed with arguments or started from stdin. I think it would make sense to also disable saving the session on quit on these circumstances. Otherwise, the existing session save file will be overwritten with the session opened with arguments without warning, which I feel is unintended behavior (or at least this is different thanauto-session
, which I migrated from).persisted.save()
, it does not respect ignored directories in the config tables. This is because internally it does not double-checkM.allowed_dir()
, even thoughautoload
andload()
does. I believesave()
should behave similarly, and theforce
option can override this as well.These issues I could fix by creating my own custom
should_save()
function, but I believe making the changes to the plugin itself would (1) help current and future users, and (2) align the plugin's behavior more closely to what's intended, at least in my opinion. Otherwise, loving this plugin!Beta Was this translation helpful? Give feedback.
All reactions