Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect observations in README.md #2

Open
conradsnicta opened this issue Jan 14, 2017 · 1 comment
Open

incorrect observations in README.md #2

conradsnicta opened this issue Jan 14, 2017 · 1 comment

Comments

@conradsnicta
Copy link

conradsnicta commented Jan 14, 2017

In the Observations section of README.md, it is stated that:

As expected Armadillo with internal BLAS/LAPACK wrappers performance is pretty poor.

This is incorrect, as the meaning of the "internal wrapper" is wrong. There is either a wrapper for an external library, or there isn't. A re-implementation of a function is not an "internal" wrapper, but simply internal functionality. The correct wording for the quoted problematic statement should be:

Armadillo without the use of OpenBLAS or MKL wrappers obtains poor performance. However, when the wrappers for OpenBLAS or MKL are enabled within Armadillo, the performance is virtually the same as for the other libraries.

@olmallet81
Copy link
Owner

Hello, you are right indeed, I will modify, thanks for noticing me and for your great work on Armadillo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants