default schema attribute changes pointer behavior for booleans

[jessepeterson]

Hello! I use go-jsonschema in "models only" mode. I notice that when a default is present or not in a schema on a boolean value this will change its pointer behavior — even for a optional/omitempty field. This isn't such a big deal for a default-false boolean field (because the omitempy tag is still there) but when a default-true boolean is not a pointer this means if the source JSON does not have that field present then it gets set to the zero value of false, which doesn't seem correct for a default-true value.

I.e. schema (with no required property):

{
  "properties":{
    "example":{
      "type":"boolean",
      "default":true
    }
  }
}

Will result in a struct with a field:

type Struct struct {
  Example bool `json:"example,omitempty"`
}

But if the input JSON being parsed is:

{}

You'll end up with Example not only present but set to false—the incorrect default type.

Also it seems if any default is present (regardless of required being present or not) then it changes to a non-pointer. But, again, this seems to make the value present when a source struct may not have had the original key.

[perher]

Hey @jessepeterson, I'm not a maintainer, but tries to follow this project.

I agree with you that when running with only models, the default value injection is not being applied, so it would be better to technically just ignore default being set. If you apply the following patch, it is enough to achieve this behavior:

diff --git a/pkg/generator/schema_generator.go b/pkg/generator/schema_generator.go
index 80cba6f..4c91e01 100644
--- a/pkg/generator/schema_generator.go
+++ b/pkg/generator/schema_generator.go
@@ -830,7 +830,7 @@ func (g *schemaGenerator) addStructField(
        }

        switch {
-       case prop.Default != nil:
+       case prop.Default != nil && !g.config.OnlyModels:
                structField.DefaultValue = g.defaultPropertyValue(prop)

        default:

This project is not so active nowdays, but feel free to open an PR with above and some added tests in tests/data/misc/onlyModels/onlyModels.json and updated codegen with OVERWRITE_EXPECTED_GO_FILE="true" make test