improve autodownload

Author: hendrikmennen

src/OneWare.Essentials/LanguageService/LanguageServiceLsp.cs

@@ -35,7 +35,6 @@ public abstract class LanguageServiceLsp(string name, string? workspace) : Langu
 
         public override async Task ActivateAsync()
         {
-            //return;
             if (IsActivated) return;
             IsActivated = true;
 

src/OneWare.Essentials/LanguageService/LanguageServiceLspAutoDownload.cs

@@ -23,16 +23,18 @@ protected LanguageServiceLspAutoDownload(IObservable<string> executablePath, Pac
         executablePath.Subscribe(x =>
         {
             ExecutablePath = x;
+            if(File.Exists(ExecutablePath))
+            {
+                _ = ActivateAsync();
+            }
         });
     }
 
     public override async Task ActivateAsync()
     {
-        if (_packageService.GetPackageModel(_package) is {Status: PackageStatus.Available or PackageStatus.UpdateAvailable or PackageStatus.Installing})
+        if (!File.Exists(ExecutablePath) && _enableAutoDownload)
         {
-            if (!_enableAutoDownload) return;
-            if(!await _packageService.InstallAsync(_package)) return;
-            await Task.Delay(100);
+            await _packageService.InstallAsync(_package);
         }
         await base.ActivateAsync();
     }

src/OneWare.Essentials/Models/PackageModel.cs

@@ -66,6 +66,8 @@ public float Progress
 
     protected string PackageType { get; }
 
+    public event EventHandler<Task<bool>>? Installing; 
+    
     public event EventHandler? Installed;
 
     public event EventHandler? Removed;
@@ -93,7 +95,16 @@ public async Task<bool> UpdateAsync(PackageVersion version)
         return target;
     }
 
-    public async Task<bool> DownloadAsync(PackageVersion version)
+    public Task<bool> DownloadAsync(PackageVersion version)
+    {
+        var task = PerformDownloadAsync(version);
+
+        Installing?.Invoke(this, task);
+        
+        return task;
+    }
+
+    private async Task<bool> PerformDownloadAsync(PackageVersion version)
     {
         try
         {
@@ -130,6 +141,8 @@ public async Task<bool> DownloadAsync(PackageVersion version)
                 InstalledVersion = version;
 
                 Installed?.Invoke(this, EventArgs.Empty);
+
+                await Task.Delay(100);
             }
             else
             {
@@ -144,7 +157,7 @@ public async Task<bool> DownloadAsync(PackageVersion version)
         }
         return true;
     }
-
+    
     /// <summary>
     /// Gets called after downloading and extracting
     /// Make sure to set Status after completing