Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.load does not work with hard-coded addresses in script code #1941

Open
jribbink opened this issue Aug 29, 2024 · 0 comments
Open

config.load does not work with hard-coded addresses in script code #1941

jribbink opened this issue Aug 29, 2024 · 0 comments
Assignees

Comments

@jribbink
Copy link
Contributor

Issue

Checking import identifier syntax type does not work properly if addresses exist in a Cadence script body as a fairly permissive global regex is used to fix 0x prefixed addresses anywhere in the Cadence script. (i.e. sending a script with getAccount(0x123) in the code)

const oldIdentifierPatternFn = () => /\b(0x\w+)\b/g

Suggested Solution

Remove this check entirely (is it needed?) or use a more robust solution for checking import type

@jribbink jribbink self-assigned this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant