Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Mobile Wallet Authentication with Discovery API #1968

Open
Tracked by #1976
jribbink opened this issue Oct 16, 2024 · 0 comments
Open
Tracked by #1976

Investigate Mobile Wallet Authentication with Discovery API #1968

jribbink opened this issue Oct 16, 2024 · 0 comments
Assignees

Comments

@jribbink
Copy link
Contributor

Problem

While it seems that the latest changes to Discovery UI have been largely successful, some time should be taken to ensure that we have parity with the Discovery API use-case.

Discovery UI currently interfaces directly with WalletConnect SignClient, however, developers using Discovery API are still relying on the old @walletconnect/modal implementation. The changes made to the Discovery UI variant were in-part due to confusion/issues with @walletconnect/modal.

There was a significant time crunch leading up to Crescendo, so Discovery API was not a priority at the time. However, this task aligns with the renewed initiative to streamline mobile wallet support this cycle.

Tasks

This path has not been seriously investigated for a couple of years now. We should begin with a discovery phase and

  1. ❗ Ensure that Discovery API still works without issue when interacting with mobile wallets (one notable discreprancy between API/UI is that there were changes to session management, we should see if these changes need to be ported to the @walletconnect/modal approach as well, or if it is OK as is...)
  2. (lower prio) Investigate the lift required to bring parity to WalletConnect authentication in Discovery API

Context

Discovery API is still an officially supported method of authentication in FCL. Some large projects on Flow still rely on this functionality (Dapper account linking AFAIK, increment.fi). We should share these latest UX gains with these consumers if it is not a heavy lift.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In Progress
Development

No branches or pull requests

1 participant