Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Mobile deep linking generates extra blank tab & doesnt work with in-app browsers #1972

Closed
Tracked by #1976
jribbink opened this issue Oct 18, 2024 · 0 comments · Fixed by #1966
Closed
Tracked by #1976
Assignees
Labels
Bug Something isn't working

Comments

@jribbink
Copy link
Contributor

Current Behavior

Currently, mobile deep linking will generate a new unnecessary tab and it will not link to the app when in an in app browser (metamask, telegram, etc.).

This "extra tab" mechanism is a historical workaround for popup blockers (esp. iOS). However, in the more recent versions of iOS, this doesn't seem to be an issue anymore if:

  • User allows popups
  • OR user has popup blocking enabled, but the time from user input -> deep link is <1000ms

Expected Behavior

Should work in all common environments without opening a new tab if achievable.

If there are edge cases where the deep link is blocked, this is OK. We can fallback to UI in #1969 to facilitate this situations.

Steps To Reproduce

n/a

Environment

n/a

What are you currently working on that this is blocking?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant