Skip to content

VSCode update breaks extension #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
istvandesign opened this issue Nov 13, 2018 · 3 comments
Open

VSCode update breaks extension #6

istvandesign opened this issue Nov 13, 2018 · 3 comments
Assignees
Labels

Comments

@istvandesign
Copy link

istvandesign commented Nov 13, 2018

Language Client for Angular @component extension:

[Error - 10:43:17 AM] Request textDocument/definition failed.
  Message: Request template/inRange failed with message: Cannot read property 'endOfFileToken' of undefined
  Code: -32603 
[Error - 10:44:45 AM] Request textDocument/definition failed.
  Message: Request template/inRange failed with message: Cannot read property 'text' of undefined
  Code: -32603 

Version: 1.29.0 (user setup)
Commit: 5f24c93878bd4bc645a4a17c620e2487b11005f9
Date: 2018-11-12T07:47:15.448Z
Electron: 2.0.12
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64

@onixie onixie self-assigned this Dec 3, 2018
@onixie onixie added the bug label Dec 3, 2018
@onixie
Copy link
Owner

onixie commented Dec 3, 2018

It seems like the first error is caused by a failure in typescript compiler host to get the source code structure. Is it possible to elaborate more about your environment or operations? I cannot reproduce the same error. Well, definitely, I think the exception should be fixed.

@istvandesign
Copy link
Author

istvandesign commented Dec 3, 2018

For some reason I couldn't reproduce the bug either. We updated the project to Angular 7 and after that I ran an npm install and now it seems to work, additionally VSCode also got some updates. Maybe there was something to do with angular 6 and the old typescript.

@onixie
Copy link
Owner

onixie commented Dec 7, 2018

Anyway, I will fix the null reference exception in case someone might encounter the same problem. Thank you for the bug report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants