Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile should use add_compile_options #141

Open
ooxi opened this issue May 27, 2017 · 0 comments
Open

Makefile should use add_compile_options #141

ooxi opened this issue May 27, 2017 · 0 comments
Labels
enhancement

Comments

@ooxi
Copy link
Owner

ooxi commented May 27, 2017 •
edited
Loading

add_compile_options was introduced in CMake 2.8.12 as an idiomatic way to specify compile options (without manually appending to CMAKE_CXX_FLAGS.

Since even Ubuntu 14.04 ships CMake 2.8.12, raising the CMake dependency to that level should not be an issue.

This issue was raised by @SoapGentoo in pull request #140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ooxi