Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finish cl_abap_zip implementation #360

Open
larshp opened this issue Jul 11, 2022 · 3 comments
Open

finish cl_abap_zip implementation #360

larshp opened this issue Jul 11, 2022 · 3 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@larshp
Copy link
Member

larshp commented Jul 11, 2022

start added in #359

somewhat possible, needed for both abapGit and abap2xslsx unit testing

@larshp larshp added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 11, 2022
@marcellourbani
Copy link

marcellourbani commented Oct 4, 2022

Wouldn't it make more sense to implement this in js? I assume it's possible, not really sure.
I'm sure you can implement deflate and ZIP headers in ABAP, but sounds like a lot of work, and pretty dumb (meaning I can think of 12 languages I'd rather use for this use case)

@larshp
Copy link
Member Author

larshp commented Oct 5, 2022

zip can call https://github.com/open-abap/open-abap/blob/main/src/cl_abap_gzip.clas.abap#L31

so its "just" sorting out all the header stuff

open-abap is meant for ABAP developers, so as much of it possible should be ABAP, as such

plus I'd like to avoid adding js dependencies from npm

@larshp
Copy link
Member Author

larshp commented Oct 5, 2022

not needed in this case, but I implemented deflate in all ABAP some years ago = https://github.com/larshp/zazlib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants