Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge VapourDepositionOnIce into Condensation dynamic (refactoring the code to make it more open to other dynamics modifying the "predicted" quantities, e.g., latent heating due to homogeneous nucleation of vapour) #1524

Open
slayoo opened this issue Mar 7, 2025 · 2 comments
Assignees

Comments

@slayoo
Copy link
Member

slayoo commented Mar 7, 2025

CC: @tluettm

@slayoo slayoo self-assigned this Mar 7, 2025
@slayoo
Copy link
Member Author

slayoo commented Mar 7, 2025

using "tendency" nomenclature/concept would make the code clearer as well, even if keeping with the current basic logic

@slayoo slayoo changed the title make Condensation logic open to other dynamics modifying the "predicted" thermodynamic quantities (e.g., other vapour deposition dynamics, but also anything related with latent heating of nucleation of vapour) merge VapourDepositionOnIce into Condensation dynamic (refactoring the code to make it more open to other dynamics modifying the "predicted" quantities, e.g., latent heating due to homogeneous nucleation of vapour) Mar 30, 2025
@slayoo
Copy link
Member Author

slayoo commented Mar 31, 2025

plan:

  • explain in a docstring how tendencies are handled for thermodynamic vars (see also the `get_predicted()` (aka tendency) logic for `Moist` environments #1545)
  • add tests with asserts on mass and energy conservation
  • merge deposition dynamic into condensation (and rename)
  • double check if recalculation of TpRH is triggered correctly in Particulator + add test
  • A&A settings -> adjust timestep after adaptive timestepping is available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant