Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use seam-connect-fake for local development #46

Closed
wants to merge 17 commits into from
Closed

Conversation

razor-x
Copy link
Member

@razor-x razor-x commented Apr 26, 2023

@vercel
Copy link

vercel bot commented Apr 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react ✅ Ready (Inspect) Visit Preview May 3, 2023 1:11am

@razor-x
Copy link
Member Author

razor-x commented Apr 26, 2023

@seveibar Feel free to work off of this branch to test the fake until it returns the devices. I think for now we can just accept any publishable key as valid until we decide how the key would be used by the fake.

@razor-x razor-x changed the title feat: Use seam-connect-fake for local storybook feat: Use seam-connect-fake for local development Apr 26, 2023
@razor-x razor-x changed the title feat: Use seam-connect-fake for local development Use seam-connect-fake for local development Apr 26, 2023
@razor-x
Copy link
Member Author

razor-x commented Apr 26, 2023

Needs seamapi/fake-seam-connect#3 and the new version from that for the port option to work.

@razor-x
Copy link
Member Author

razor-x commented Apr 26, 2023

Note that I really tried to get jest to start and stop the fake, but all efforts failed so I fellback to using concurrently.

@razor-x razor-x mentioned this pull request Apr 26, 2023
@razor-x razor-x marked this pull request as ready for review April 26, 2023 22:20
@razor-x razor-x requested a review from azat-co as a code owner April 26, 2023 22:20
@razor-x razor-x requested review from seveibar and removed request for azat-co April 26, 2023 22:20
@razor-x
Copy link
Member Author

razor-x commented Apr 26, 2023

@seveibar This is working with Jest now. We shouldn't merge this though until the fake is updated with more endpoints.

@seveibar
Copy link
Contributor

@razor-x yep! Hopefully i will have a good batch of endpoints tonight!!!

This was linked to issues Apr 27, 2023
@razor-x razor-x added the devx Developer tooling and experience label Apr 27, 2023
@stale
Copy link

stale bot commented Apr 30, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@razor-x
Copy link
Member Author

razor-x commented May 3, 2023

Closing in favor of #75

@razor-x razor-x closed this May 3, 2023
@razor-x razor-x deleted the seam-connect-fake branch May 12, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devx Developer tooling and experience
Projects
None yet
2 participants