Skip to content

Method GetIdentity for CD format versions not fixed #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mandelsoft opened this issue Jan 11, 2025 · 2 comments · May be fixed by #1247
Open

Method GetIdentity for CD format versions not fixed #1246

mandelsoft opened this issue Jan 11, 2025 · 2 comments · May be fixed by #1247
Labels
area/ipcei Important Project of Common European Interest kind/bugfix Bug lifecycle/stale Nobody worked on this for 6 months (will further age)

Comments

@mandelsoft
Copy link
Contributor

What happened:

With v0.19.0 the method GetIdentity was fixed for the internal CD version. Unfortunately this fix was not done for the appropriate methods on
the format versions.

As a result, for resource sets like

- access: null
  extraIdentity:
    version: v1
  name: res
  type: ""
  version: v1
- access: null
  name: res
  type: ""
  version: v2

with a mixed specification of a required version field in the extra identity, the identity is not correctly calculated (for the second resource, the version is not part of the identity).

This method is only used by the local CD validation. User coding is not affected, but therefore the method cannot be removed at all.

What you expected to happen:

For both resources the version must be part of the identity.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know:

Environment:
@github-actions github-actions bot added the area/ipcei Important Project of Common European Interest label Jan 11, 2025
@mandelsoft mandelsoft linked a pull request Jan 11, 2025 that will close this issue
Open
@jakobmoellerdev
Copy link
Contributor

Previously I believe the behavior was that the version was only part of the identity for the first resource, not the second. Where is this behavior incorrect currently?

@github-actions GitHub Actions
Copy link
Contributor

This issue was marked as stale because it has not had recent activity.

@github-actions github-actions bot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ipcei Important Project of Common European Interest kind/bugfix Bug lifecycle/stale Nobody worked on this for 6 months (will further age)
Projects
OCM Backlog Board
Status: 🆕 ToDo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix versioned GetIdentity methods mandelsoft/ocm
2 participants
@mandelsoft @jakobmoellerdev